Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
100 commits
Select commit Hold shift + click to select a range
73bd1ef
DC v2: includes TFLight fix and new dc beta time walk with constants …
raffaelladevita Mar 24, 2025
f1aaaca
Update DC reconstruction at the denoisinng level (#499)
tongtongcao Mar 24, 2025
8924938
reset limit for prob in DC clustering and cancel requirement that no …
tongtongcao Mar 24, 2025
3951351
pass 2 additional values
baltzell Mar 24, 2025
a028252
fix data type
baltzell Mar 24, 2025
b13d761
feat: pre-commit hook to update banks README (#505)
c-dilks Mar 26, 2025
970b025
Change the option to select the track finding to a enum.
mathieuouillon Mar 3, 2025
1ef51d5
Change the default options for DJL:
mathieuouillon Mar 3, 2025
ce1e25f
Modification of the track candidates generation
mathieuouillon Mar 25, 2025
a107bc3
Improve the function to get all the track candidates.
mathieuouillon Mar 25, 2025
3f00dfa
Update AHDCEngine to initialize model conditionally and adjust predic…
mathieuouillon Mar 25, 2025
e20330f
New features for ALERT Kalman filter+optimized parameters (#445)
efuchey Mar 27, 2025
3b01ae6
Petiroc timestamps2 (#512)
whit2333 Mar 27, 2025
4934533
bump version
baltzell Mar 25, 2025
9c2f6cc
version bump
raffaelladevita Mar 28, 2025
e5ce2ab
create a method to decode evio events in a single line to simplify us…
raffaelladevita Mar 28, 2025
ed6fb2b
new DCRB firmware (#509)
raffaelladevita Mar 28, 2025
881cce5
fix: remove `jdtls` files
c-dilks Mar 28, 2025
56f30ae
fix: ignore `jdtls` files
c-dilks Mar 28, 2025
339ee45
Use pulse time and hide MVTFitter
ftouchte Mar 30, 2025
989b573
Change samplingTime
ftouchte Mar 30, 2025
8c2346b
Fix issue
ftouchte Mar 30, 2025
70d225e
version bump
baltzell Mar 30, 2025
d07bcb6
default to clondaq7, add where missing
baltzell Apr 1, 2025
c1a4ca2
Load calibration constants for AHDC and ATOF
ftouchte Apr 3, 2025
3aedccc
Correct atof calibration constant name
ftouchte Apr 3, 2025
2879144
Compute doca from time2distance calibration
ftouchte Apr 3, 2025
4f16d92
Add a time in the AHDC::Hits bank
ftouchte Apr 3, 2025
b11c8ac
Try to load ccdb tables
ftouchte Apr 3, 2025
73a864a
ALERT CCDB successfully loaded
ftouchte Apr 4, 2025
32abeed
Delete unnecessary comments
ftouchte Apr 4, 2025
4659ff4
remove duplicate call
baltzell Apr 4, 2025
ea196ca
catch what looks like v2 firmware and ignore it
baltzell Apr 4, 2025
6b02fd2
cleanup IDE complaints
baltzell Apr 4, 2025
77b67cd
Alert engine for combined ATOF/AHDC reconstruction (#529)
whit2333 Apr 6, 2025
080c330
build(deps): bump com.github.spotbugs:spotbugs-maven-plugin
dependabot[bot] Mar 31, 2025
3af243f
Apply cuts on AHDC hits to be processed
ftouchte Apr 7, 2025
73f8884
ci: use OpenJDK 24 on runner
c-dilks Apr 8, 2025
912a3f6
fix: restrict to javadoc job
c-dilks Apr 8, 2025
8d9424c
doc: clarify comment
c-dilks Apr 8, 2025
14a3b5c
Write time in AHDC::Hits bank
ftouchte Apr 8, 2025
a31270a
fix indentation
baltzell Apr 7, 2025
b07c9b4
reduce to 30 samples
baltzell Apr 7, 2025
c90518e
bump version
baltzell Apr 8, 2025
2f0322b
Change geometry for the hits to match reality. (90 shift + conterclock)
mathieuouillon Apr 8, 2025
4969105
add all rg-l banks to all schema for now
baltzell Apr 9, 2025
b2babd8
initialize AHDC geometry, currently only for test coverage
baltzell Apr 9, 2025
a21aa3d
add RG-L engines to defaults
baltzell Apr 9, 2025
1dfa223
fix: geometry order of points that define the wire cell to satify a C…
mathieuouillon Apr 9, 2025
6fbfa00
bump version
baltzell Apr 9, 2025
a854a60
Looping on all track candidates in Kalman filter instead of the first…
efuchey Apr 9, 2025
b1d6e4c
Add new entries in AHDC::Track, KFTrack and Hits
ftouchte Apr 10, 2025
3599985
Fill attributes of AHDC::Tracks, KFTrack, Hits
ftouchte Apr 10, 2025
9ce6bd4
bump version
baltzell Apr 11, 2025
b2aa46a
build(deps): bump org.jacoco:jacoco-maven-plugin from 0.8.12 to 0.8.13
dependabot[bot] Apr 14, 2025
d9d4ea6
build(deps): bump org.apache.maven.plugins:maven-compiler-plugin
dependabot[bot] Apr 14, 2025
f1f822f
Normalise bank name in alert.json
ftouchte Apr 11, 2025
4ccc31a
Bank names are nomalized for AHDC
ftouchte Apr 11, 2025
37689aa
Start normalisation of ATOF bank name
ftouchte Apr 11, 2025
c53ef78
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 11, 2025
d5e8961
Update bank names for ALERT rojections and AI
ftouchte Apr 11, 2025
c7bc9af
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 11, 2025
678809c
add an rg-l single-event test
baltzell Apr 11, 2025
9464397
make it runnable
baltzell Apr 11, 2025
86865a2
add test event
baltzell Apr 11, 2025
0d506d7
register output banks
baltzell Apr 11, 2025
603817d
switch engines
baltzell Apr 11, 2025
d6670a7
Update AHDCTest.java
ftouchte Apr 11, 2025
ec15414
add header info to test event
ftouchte Apr 11, 2025
8ba6bba
Make test pass
ftouchte Apr 11, 2025
21dce64
Fix test
ftouchte Apr 11, 2025
ac0adcb
Fix version number
ftouchte Apr 11, 2025
396094a
Revert "fix: geometry order of points that define the wire cell to sa…
baltzell Apr 12, 2025
e24508a
Revert "Change geometry for the hits to match reality. (90 shift + co…
baltzell Apr 12, 2025
699fd15
redefine AHDC wires to have the first wire at phi~0 and wire number i…
raffaelladevita Apr 15, 2025
bc6c11f
shift the AHDC center to z=0, improve code clarity
raffaelladevita Apr 15, 2025
b6ae96c
replaced hardcoded geometry calculations in hit definition with info …
raffaelladevita Apr 15, 2025
1b8b52e
one more modification to AHDC wire numbering to have first wire eithe…
baltzell Apr 16, 2025
20d8d3f
Load raw hit cuts for ahdc from ccdb (#572)
ftouchte Apr 17, 2025
3a29148
Add conventional tracking into ai-assisted tracking as complementary …
tongtongcao Apr 17, 2025
a0c0a1e
Fixes to bank schema and constants loading (#574)
raffaelladevita Apr 17, 2025
f772c46
center the atof at z=0 (#579)
N-Plx Apr 19, 2025
a6c50d7
build(deps): bump org.apache.commons:commons-text from 1.13.0 to 1.13…
dependabot[bot] Apr 21, 2025
496c850
Really add all RG-L banks to calib/mon/dst schema (#585)
baltzell Apr 21, 2025
76a051a
use logger (#586)
baltzell Apr 21, 2025
61fa188
restore
baltzell Apr 21, 2025
d53e5ff
Add a 2-particle RG-L EB test (#575)
baltzell Apr 21, 2025
d6d63aa
Use SQLite snapshot from CVMFS for CI jobs (#576)
baltzell Apr 21, 2025
eafc3b1
ci: set CCDB URI for full workflow (#591)
c-dilks Apr 22, 2025
938192c
fix atof geometry service (#593)
N-Plx Apr 23, 2025
6649f8a
feat: ATOF test and single event file (#597)
N-Plx Apr 23, 2025
6287832
added new AI-assisted network for RG-D Fall23 (#600)
mathieuouillon Apr 25, 2025
a005cc8
fix an issue in DCHBPostClusterAI (#589)
tongtongcao Apr 26, 2025
d4f13a5
Fix: AHDC: use ahdcExtractor to process simulation (#607)
mathieuouillon May 2, 2025
7fcb909
feat: generate `mkdocs` webpage, and get rid of pre-commit (#609)
c-dilks May 2, 2025
0841d5f
fix: `hipo-multi-merge` Slurm node memory request should be at least …
c-dilks May 3, 2025
efc41eb
use -- to differentiate jvm/class options (#608)
baltzell May 3, 2025
f71020d
build(deps): bump org.slf4j:slf4j-simple from 2.0.16 to 2.0.17 (#602)
dependabot[bot] May 5, 2025
f2b5ec0
version bump (#610)
baltzell May 5, 2025
0aacaee
Revert "DC v2: includes TFLight fix and new dc beta time walk with co…
baltzell May 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .containers/coatjava.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ ARG REF_NAME=development
# build coatjava
RUN java --version && cd /opt && \
git clone https://code.jlab.org/hallb/alert/coatjava.git && cd coatjava && \
git fetch origin && git checkout ${REF_NAME} && ./build-coatjava.sh --quiet
git fetch origin && git checkout ${REF_NAME} && ./build-coatjava.sh --quiet && \
./install-clara /opt/clara
14 changes: 14 additions & 0 deletions .containers/coatjava.def
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Bootstrap: docker
From: codecr.jlab.org/hallb/alert/coatjava/coatjava:{{ REF_NAME }}


%environment
export CLAS12DIR=/opt/coatjava/coatjava

%help
This is a clas12 coatjava container used to run coatjava on HPC systems
and do rapid development.

%labels
Author Whitney Armstrong warmstrong@anl.gov
REF_NAME {{ REF_NAME }}
72 changes: 38 additions & 34 deletions .github/workflows/maven.yml → .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ defaults:
env:
java_version: 17
java_distribution: zulu
javadoc_version: 24 # newer than `java_version` for better javadoc
groovy_version: 4.x
CCDB_CONNECTION: 'sqlite:////cvmfs/oasis.opensciencegrid.org/jlab/hallb/clas12/sw/noarch/data/ccdb/ccdb_latest.sqlite'

jobs:

Expand All @@ -40,11 +42,17 @@ jobs:
runs-on: ${{ matrix.runner }}
steps:
- uses: actions/checkout@v4
- name: Set up JDK
uses: actions/setup-java@v4
- uses: actions/setup-java@v4
with:
java-version: ${{ env.java_version }}
distribution: ${{ env.java_distribution }}
- uses: cvmfs-contrib/github-action-cvmfs@v5
with:
cvmfs_repositories: 'oasis.opensciencegrid.org'
- name: cvmfs
run: ls /cvmfs/oasis.opensciencegrid.org/jlab/hallb/clas12/sw/noarch/data/ccdb/ccdb_latest.sqlite
- name: echo CCDB_CONNECTION
run: echo $CCDB_CONNECTION
- name: build
run: ./build-coatjava.sh --spotbugs --unittests --quiet -T4
- name: tar # tarball to preserve permissions
Expand Down Expand Up @@ -103,8 +111,13 @@ jobs:
- uses: actions/download-artifact@v4
with:
name: build_${{ matrix.runner }}
- uses: cvmfs-contrib/github-action-cvmfs@v5
with:
cvmfs_repositories: 'oasis.opensciencegrid.org'
- name: untar build
run: tar xzvf coatjava.tar.gz
- name: echo CCDB_CONNECTION
run: echo $CCDB_CONNECTION
- name: run test
run: |
cd validation/advanced-tests
Expand Down Expand Up @@ -160,55 +173,46 @@ jobs:
- name: pass
run: exit 0

# generate documentation
# documentation
#############################################################################

generate_documentation:
runs-on: ubuntu-latest
needs: [ build ]
steps:
### mkdocs
- uses: actions/checkout@v4
- name: Set up JDK
uses: actions/setup-java@v4
with:
java-version: ${{ env.java_version }}
distribution: ${{ env.java_distribution }}
- name: build
run: ./build-coatjava.sh
- name: generate documentation
run: ./build-javadocs.sh
- uses: actions/upload-artifact@v4
with:
name: javadoc
path: docs/javadoc/
retention-days: 1

# deploy web pages
#############################################################################

collect_webpages:
if: ${{ github.ref == 'refs/heads/development' }}
needs: [ build, generate_documentation ]
runs-on: ubuntu-latest
steps:
- name: download jacoco report
- name: install mkdocs dependencies
run: python -m pip install -r docs/mkdocs/requirements.txt
- name: generate mkdocs
run: docs/mkdocs/generate.sh pages
### jacoco
- name: download jacoco report artifact
uses: actions/download-artifact@v4
with:
name: jacoco_report
path: pages/jacoco
- name: download javadoc documentation
uses: actions/download-artifact@v4
### javadoc
- name: set up JDK
uses: actions/setup-java@v4
with:
name: javadoc
path: pages/javadoc
- run: tree pages
java-version: ${{ env.javadoc_version }}
distribution: ${{ env.java_distribution }}
- name: build coatjava
run: ./build-coatjava.sh
- name: generate javadoc documentation
run: |
./build-javadocs.sh
mv docs/javadoc pages/
### upload artifacts
- uses: actions/upload-pages-artifact@v3
with:
retention-days: 1
retention-days: 7
path: pages/

deploy_web_pages:
if: ${{ github.ref == 'refs/heads/development' }}
needs: collect_webpages
needs: [ generate_documentation ]
permissions:
pages: write
id-token: write
Expand Down
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ hs_err_pid*
*.iml
.idea

# eclipse JDT language server
.classpath
.factorypath
.project
.settings

# no log files:
*.log
*.evio
Expand Down
32 changes: 32 additions & 0 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ workflow:

variables:
KUBERNETES_MEMORY_LIMIT: "8Gi"
REF_NAME: ${CI_COMMIT_REF_NAME}

default:
image: ubuntu:noble
Expand Down Expand Up @@ -69,3 +70,34 @@ shared_for_alert_tests:
project: hallb/alert/atof/shared_for_alert
strategy: depend

coatjava:singularity:
image: eicweb.phy.anl.gov:4567/containers/image_recipes/ubuntu_dind:latest
needs: ["coatjava_build"]
tags:
- silicon
allow_failure: true
script:
- apptainer build --build-arg REF_NAME=${REF_NAME} coatjava.sif .containers/coatjava.def
- ls -lrth
artifacts:
paths:
- coatjava.sif

create-pages:
image: codecr.jlab.org/hallb/alert/coatjava/coatjava:development
script:
- export MAVEN_OPTS=" -Dfile.encoding=UTF-8"
- echo "${CI_COMMIT_REF_NAME}"
- ls -lrth
- mvn --version
- java --version
- ls -lrth
- pwd
- ls -lrth docs/javadoc
- ./build-javadocs.sh
- ls -lrth
- ls -lrth docs/
- ls -lrth docs/javadoc
- mv docs/javadoc public
pages: true # specifies that this is a Pages job and publishes the default public directory

4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
[![Validation Status](https://github.com/JeffersonLab/coatjava/actions/workflows/validation.yml/badge.svg)](https://github.com/JeffersonLab/coatjava/actions/workflows/validation.yml)
[![Coverage](https://badgen.net/static/JaCoCo/coverage/purple)](https://jeffersonlab.github.io/coatjava/jacoco)

- [**Documentation Homepage**](https://jeffersonlab.github.io/coatjava)
- [API Documentation (Javadoc)](https://jeffersonlab.github.io/coatjava/javadoc)

----
Expand Down Expand Up @@ -58,3 +59,6 @@ http://stackoverflow.com/questions/600079/how-do-i-clone-a-subdirectory-only-of-

-->


[Coatjava Apptainer](https://code.jlab.org/hallb/alert/coatjava/-/jobs/artifacts/development/raw/coatjava.sif?job=coatjava%3Asingularity)

4 changes: 3 additions & 1 deletion bin/hipo-multi-merge
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ def print_log(name, val)
puts name.rjust(30) + " = #{val}"
end

SlurmMemReq = 2048 + 200 # `-Xmx` argument from `hipo-utils`, plus extra padding

# user options
@args = OpenStruct.new
@args.inputs = nil
Expand Down Expand Up @@ -76,7 +78,7 @@ if @args.use_batch
'job-name' => "hipo_multi_merge___#{@args.prefix}",
'account' => 'clas12',
'partition' => 'production',
'mem-per-cpu' => 500,
'mem-per-cpu' => SlurmMemReq,
'time' => '1:00:00',
'ntasks' => 1,
'cpus-per-task' => 1,
Expand Down
7 changes: 5 additions & 2 deletions bin/recon-util
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@

. `dirname $0`/../libexec/env.sh

split_cli $@

export MALLOC_ARENA_MAX=1

java -Xmx1536m -Xms1024m -XX:+UseSerialGC \
java -Xmx1536m -Xms1024m -XX:+UseSerialGC ${jvm_options[@]} \
-cp "$CLAS12DIR/lib/clas/*:$CLAS12DIR/lib/services/*:$CLAS12DIR/lib/utils/*" \
org.jlab.clas.reco.EngineProcessor \
$*
${class_options[@]}

4 changes: 3 additions & 1 deletion build-javadocs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@

set -e

export MAVEN_OPTS=" -Dfile.encoding=UTF-8"

##### generate documentation
mvn javadoc:javadoc -Ddoclint=none
mvn javadoc:javadoc -Ddoclint=none


##### collect documentation
Expand Down
6 changes: 3 additions & 3 deletions common-tools/clara-io/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.jlab.clas</groupId>
<artifactId>clara-io</artifactId>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
<packaging>jar</packaging>

<parent>
<groupId>org.jlab.clas</groupId>
<artifactId>clas12rec</artifactId>
<relativePath>../../parent/pom.xml</relativePath>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
</parent>

<dependencies>
Expand Down Expand Up @@ -61,7 +61,7 @@
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-text</artifactId>
<version>1.13.0</version>
<version>1.13.1</version>
</dependency>

</dependencies>
Expand Down
20 changes: 10 additions & 10 deletions common-tools/clas-analysis/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,63 +3,63 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.jlab.clas</groupId>
<artifactId>clas-analysis</artifactId>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
<packaging>jar</packaging>

<parent>
<groupId>org.jlab.clas</groupId>
<artifactId>clas12rec</artifactId>
<relativePath>../../parent/pom.xml</relativePath>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
</parent>

<dependencies>
<dependency>
<groupId>org.jlab.clas</groupId>
<artifactId>clas-utils</artifactId>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
</dependency>

<dependency>
<groupId>org.jlab.clas</groupId>
<artifactId>clas-physics</artifactId>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
</dependency>

<dependency>
<groupId>org.jlab.clas</groupId>
<artifactId>clas-io</artifactId>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
</dependency>

<dependency>
<groupId>org.jlab.clas</groupId>
<artifactId>clas-geometry</artifactId>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
</dependency>

<dependency>
<groupId>org.jlab.clas</groupId>
<artifactId>clas-jcsg</artifactId>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
</dependency>

<dependency>
<groupId>org.jlab.clas</groupId>
<artifactId>swim-tools</artifactId>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
</dependency>

<dependency>
<groupId>org.jlab.clas</groupId>
<artifactId>clas-detector</artifactId>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
</dependency>

<dependency>
<groupId>org.jlab.clas</groupId>
<artifactId>clas-reco</artifactId>
<version>11.1.2-SNAPSHOT</version>
<version>12.0.6t-SNAPSHOT</version>
</dependency>
</dependencies>

Expand Down
Loading