Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,23 @@ public void removeAuthorizer(BigInteger facilityId, OperationsType type, String
@PermitAll
public void isAuthorizer(Facility facility, OperationsType type, String username)
throws UserFriendlyException {
boolean authorizer = isAuthorizerBool(facility, type, username);

if (!authorizer) {
throw new UserFriendlyException("Not Authorized to Authorize!");
}
}

@PermitAll
public boolean isAuthorizerBool(Facility facility, OperationsType type, String username) {
List<Authorizer> authorizerList = filterList(facility, type, username);

boolean authorizer = true;

if (authorizerList == null || authorizerList.isEmpty()) {
throw new UserFriendlyException("Not Authorized to Authorize!");
authorizer = false;
}

return authorizer;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import javax.servlet.http.HttpServletResponse;
import org.jlab.jam.business.session.*;
import org.jlab.jam.persistence.entity.*;
import org.jlab.jam.persistence.enumeration.OperationsType;
import org.jlab.jam.persistence.view.FacilityExpirationEvent;

/**
Expand All @@ -33,6 +34,7 @@ public class FacilityAuthorization extends HttpServlet {
@EJB RFSegmentFacade rfSegmentFacade;
@EJB ExpirationManager expirationManager;
@EJB NotificationManager notificationManager;
@EJB AuthorizerFacade authorizerFacade;

/**
* Handles the HTTP <code>GET</code> method.
Expand Down Expand Up @@ -143,7 +145,24 @@ private void handleFacility(
Map<BigInteger, RFSegmentAuthorization> segmentAuthorizationMap =
rfAuthorizationFacade.createSegmentAuthorizationMap(rfAuthorization);

String username = request.getRemoteUser();

boolean isRfEditable = false;
boolean isBeamEditable = false;

if (username != null) {
if (request.isUserInRole("jam-admin")) {
isRfEditable = true;
isBeamEditable = true;
} else {
isRfEditable = authorizerFacade.isAuthorizerBool(facility, OperationsType.RF, username);
isBeamEditable = authorizerFacade.isAuthorizerBool(facility, OperationsType.BEAM, username);
}
}

request.setAttribute("unitsMap", beamAuthorizationFacade.getUnitsMap());
request.setAttribute("isRfEditable", isRfEditable);
request.setAttribute("isBeamEditable", isBeamEditable);
request.setAttribute("rfAuthorization", rfAuthorization);
request.setAttribute("beamAuthorization", beamAuthorization);
request.setAttribute("rfList", rfList);
Expand Down
7 changes: 4 additions & 3 deletions src/main/webapp/WEB-INF/tags/authorizations-panel.tag
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
<%@taglib prefix="t" tagdir="/WEB-INF/tags"%>
<%@attribute name="rfList" required="true" type="java.util.List"%>
<%@attribute name="beamList" required="true" type="java.util.List"%>
<%@attribute name="isEditable" required="true" type="java.lang.Boolean"%>
<%@attribute name="isRfEditable" required="true" type="java.lang.Boolean"%>
<%@attribute name="isBeamEditable" required="true" type="java.lang.Boolean"%>
<%@attribute name="isHistory" required="true" type="java.lang.Boolean"%>
<div id="authorization-panel">
<div class="chart-wrap-backdrop">
Expand All @@ -19,7 +20,7 @@
<input type="hidden" name="facilityId" value="${facility.facilityId}">
<div class="control-panel">
<div class="control-item edit-button-panel">
<c:if test="${isEditable}">
<c:if test="${isRfEditable}">
<span class="readonly-field"><button id="rf-edit-button" type="button">Edit RF Operations</button></span>
</c:if>
<div class="editable-field">
Expand Down Expand Up @@ -48,7 +49,7 @@
<input type="hidden" name="facilityId" value="${facility.facilityId}">
<div class="control-panel">
<div class="control-item edit-button-panel">
<c:if test="${isEditable}">
<c:if test="${isBeamEditable}">
<span class="readonly-field"><button id="beam-edit-button" type="button">Edit Beam Operations</button></span>
</c:if>
<div class="editable-field">
Expand Down
2 changes: 1 addition & 1 deletion src/main/webapp/WEB-INF/views/facility-authorization.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<jsp:body>
<section>
<h2><c:out value="${facility.name}"/></h2>
<t:authorizations-panel rfList="${rfList}" beamList="${beamList}" isEditable="${pageContext.request.isUserInRole('jam-admin')}" isHistory="${false}"/>
<t:authorizations-panel rfList="${rfList}" beamList="${beamList}" isRfEditable="${isRfEditable}" isBeamEditable="${isBeamEditable}" isHistory="${false}"/>
</section>
<div id="success-dialog" class="dialog" title="Authorization Saved Successfully">
<span class="logentry-success">A new log entry was created: <a id="new-entry-url" href="#"></a></span>
Expand Down
2 changes: 1 addition & 1 deletion src/main/webapp/WEB-INF/views/inventory/authorizers.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
<c:forEach items="${authorizerList}" var="authorizer">
<tr data-username="${fn:escapeXml(authorizer.authorizerPK.username)}" data-facility-id="${authorizer.authorizerPK.facility.facilityId}">
<td><c:out value="${authorizer.authorizerPK.facility.name}"/></td>
<td><c:out value="${authorizer.authorizerPK.operationsType.label}"/></td>
<td><c:out value="${authorizer.authorizerPK.operationsType}"/></td>
<td><c:out value="${s:formatUsername(authorizer.authorizerPK.username)}"/></td>
</tr>
</c:forEach>
Expand Down
Loading