take into account sysctl deprecation in modern linux kernels #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Peter, Martin and Bartek to contributors.
Update AUTHORS
…aviour results in far too many compiler instances being launched if nothing is specified at configuration time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://www.phoronix.com/news/Linux-5.5-Kills-SYSCTL-SYSCALL,
sys/sysctl.hhas been deprecated for a while, as a result of which QPhiX and/or applications using it fail to build on some systems (such as on github's CI runners).This seems to fix the issue in the sense that it requires
sysconfto be available ifsysctlis not. I'm not actually sure that eithersys/types.horsys/sysctl.hare required for using__rdtscbut I don't know so I wanted to make a minimal change which preserves the status quo ofsys/sysctl.his available.Note that for testing reasons I had to include #121 in here as well.