This repository was archived by the owner on Sep 23, 2020. It is now read-only.
XSS vulnerability fixed. [ High Priority ] #66
Open
DrHazemAli wants to merge 1 commit intoJeremyFagis:masterfrom
Open
XSS vulnerability fixed. [ High Priority ] #66DrHazemAli wants to merge 1 commit intoJeremyFagis:masterfrom
DrHazemAli wants to merge 1 commit intoJeremyFagis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
There is an XSS vulnerability inside dropify.min.js allows client-side to perform JS actions when the image being uploaded in the preview inner because the filename itself can be renamed to an html or javascript code.
Example : (">< img src = x onerror=prompt(1) >.png)
Org:
this.filenameWrapper.children(".dropify-filename-inner").html(this.file.name);
Fixes :
this.filenameWrapper.children(".dropify-filename-inner").html(cleanHTMLi(this.file.name));
I've written a function to perform HTML cleanup:
function cleanHTMLi(s) {
return s.replace(/&/g, '&').replace(/</g, '<').replace(/"/g, '"');
}
Thanks,