Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 22, 2026

Addresses code quality feedback from PR #71 review comments: redundant boolean comparisons and committed test artifacts.

Changes

  • Simplified boolean expressions across test assertions:

    • == false! operator
    • == true on nullable results → ?? false null-coalescing pattern
    • Affected: ProfileAttributeTests, DetectSqlProjectTests, JsonTimeSpanConverterTests, RunEfcptTests
  • Added tests/**/TestResults/ to .gitignore to exclude coverage reports and test output artifacts

Example

// Before
.Then("Exclude is false by default", attr => attr.Exclude == false)
.And("error mentions ProjectPath", r => r.Setup.Engine.Errors[0].Message?.Contains("ProjectPath") == true)

// After  
.Then("Exclude is false by default", attr => !attr.Exclude)
.And("error mentions ProjectPath", r => r.Setup.Engine.Errors[0].Message?.Contains("ProjectPath") ?? false)

The EfcptEnsureDacpacEfcptEnsureDacpacBuilt target rename noted in reviews was verified as intentional (critical bug fix in ea8f95f).


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 22, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • invalid
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/JD.Efcpt.Build/JD.Efcpt.Build/tests/JD.Efcpt.Build.Tests/bin/Debug/net10.0/JD.Efcpt.Build.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/JD.Efcpt.Build/JD.Efcpt.Build/tests/JD.Efcpt.Build.Tests/bin/Debug/net10.0/JD.Efcpt.Build.Tests.deps.json /home/REDACTED/work/JD.Efcpt.Build/JD.Efcpt.Build/tests/JD.Efcpt.Build.Tests/bin/Debug/net10.0/testhost.dll --port 46789 --endpoint 127.0.0.1:046789 --role client --parentprocessid 4041 --telemetryoptedin false (dns block)
  • www.example.com
    • Triggering command: /opt/oracle/product/21c/dbhomeXE/bin/oracle oracleXE (DESCRIPTION=(LOCAL=YES)(ADDRESS=(PROTOCOL=beq))) 1fb8026a20e26695-c e669d30257a3d0c9fsync=off 06cd�� --root 51a2e5b865b11457-c /usr/bin/runc.orsynchronous_commit=off 51a2e5b865b11457bash (dns block)
    • Triggering command: /opt/oracle/product/21c/dbhomeXE/bin/oracle oracleXE (DESCRIPTION=(LOCAL=YES)(ADDRESS=(PROTOCOL=beq))) (dns block)
    • Triggering command: /opt/oracle/product/21c/dbhomeXE/bin/oracle oracleXE (DESCRIPTION=(LOCAL=YES)(ADDRESS=(PROTOCOL=beq))) docker0 csi/net-interface-handler --wa�� -t y 723160ad4a7480dd8836b7d30344509a1e1/log.json b7d2b61199a81929/usr/sbin/iptables (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Convert JD.Efcpt.Build to use JD.MSBuild.Fluent Simplify boolean comparisons and exclude test artifacts from git Jan 22, 2026
Copilot AI requested a review from JerrettDavis January 22, 2026 15:25
@JerrettDavis JerrettDavis marked this pull request as ready for review January 22, 2026 15:28
@JerrettDavis JerrettDavis merged commit c834620 into feature/convert-to-fluent Jan 22, 2026
@JerrettDavis JerrettDavis deleted the copilot/sub-pr-71 branch January 22, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants