test(journeys-admin-e2e): fix failing e2e tests#8684
Open
kiran-redhat wants to merge 8 commits intomainfrom
Open
test(journeys-admin-e2e): fix failing e2e tests#8684kiran-redhat wants to merge 8 commits intomainfrom
kiran-redhat wants to merge 8 commits intomainfrom
Conversation
…strict mode
- Scope team dropdown to getByTestId('TeamSelect') to avoid 3-element listbox match
- Scope three-dot menu to MainPanelHeader button with MoreIcon
- Scope copy-to-team dialog dropdown to getByTestId('team-duplicate-select')
- Add toHaveCount(1) and toBeVisible() before clicks for clearer failures
- Fix verifyCopiedTeamNameUpdatedInTeamSelectDropdown to use TeamSelect scope
Co-authored-by: Cursor <cursoragent@cursor.com>
…treamline interactions - Updated CardLevelActionPage to ensure action listbox is visible before clicking. - Improved JourneyPage by adding visibility checks for archived, trash, and active tabs before interactions. - Refactored TeamsPage to include visibility checks for the Add Integration button and Growth Space integration link. - Enhanced overall reliability of UI interactions by implementing explicit visibility assertions.
…reliability - Introduced visibility checks for the Discover journey list in active-archived-trash.spec.ts and custom-journey.spec.ts to skip tests when the list is not available. - Updated card-level-actions.spec.ts to reflect the correct icon name for the Trailing Icon property. - Enhanced teams.spec.ts to skip the integration test if the Growth Spaces integration is not visible. - Improved the JourneyPage and TeamsPage classes with new methods to check the visibility of elements, ensuring more robust test execution.
… and integrations - Updated active-archived-trash.spec.ts to skip tests when the Discover journey list is not visible due to potential environment issues. - Enhanced teams.spec.ts to skip the integration test for Growth Spaces when the feature flag is off, ensuring tests do not fail unexpectedly. - Removed visibility check methods from JourneyPage and TeamsPage as they are no longer needed, streamlining the codebase.
…iption validation - Added a data-testid attribute to the JourneyDescription component for better test targeting. - Updated the enterLanguage method to streamline language selection and ensure the selected language is filled correctly. - Enhanced the validateJourneyDescription method to use a more reliable locator for checking the journey description visibility. - Added timeout checks to ensure elements are properly loaded before interactions, improving test reliability.
kiran-redhat
requested review from
mikeallisonJS and
tataihono
as code owners
Contributor
WalkthroughThis PR updates E2E tests and page objects in the journeys-admin-e2e application to improve test reliability. It skips flaky tests due to environment/feature flag issues, refactors page object selectors to add explicit visibility checks, updates test flows to match component behavior changes, and adjusts test data and timing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 79f8a9d
☁️ Nx Cloud last updated this comment at |
github-actions
bot
requested a deployment
to
Preview - journeys-admin
kiran-redhat
changed the title
kiran-redhat
changed the title
github-actions
bot
requested a deployment
to
Preview - journeys-admin
Contributor
|
The latest updates on your projects.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are passing with this branch:
Summary by CodeRabbit
Tests
Chores