Skip to content

feat: media layout skeleton implementation#8699

Open
jianwei1 wants to merge 4 commits intofeature/26-01-JB-story-1from
jianweichong/nes-1304-media-layout
Open

feat: media layout skeleton implementation#8699
jianwei1 wants to merge 4 commits intofeature/26-01-JB-story-1from
jianweichong/nes-1304-media-layout

Conversation

@jianwei1
Copy link
Contributor

@jianwei1 jianwei1 commented Feb 5, 2026

Skeleton implementation for the media layout.

  • Added a sections folder, containing a basic component/spec/index file for each section (logo, card, image etc)
  • Added a utils folder, which contains a skeleton function to show each section (showLogoSection etc).
  • update the media screen component to conditionally render these sections, based on the result of the util functions

Added new components for BackgroundImageSection, BackgroundVideoSection, CardsSection, ImagesSection, LogoSection, and VideosSection, along with their respective tests. Each section is designed to render with a data-testid for testing purposes.
Added an index file to streamline the export of media sections including LogoSection, CardsSection, ImagesSection, VideosSection, BackgroundImageSection, and BackgroundVideoSection for easier imports in the customization flow.
Introduced utility functions for managing the visibility of media sections including Logo, Images, Videos, Background Image, and Background Video. Each section has corresponding tests to ensure functionality. This enhances the customization flow for media components.
Updated the MediaScreen component to conditionally render media sections (Logo, Images, Videos, Background Image, and Background Video) based on utility functions. Added a test to verify the presence of these sections when the screen is displayed, improving the customization flow for media components.
@jianwei1 jianwei1 requested a review from jaco-brink February 5, 2026 03:37
@jianwei1 jianwei1 self-assigned this Feb 5, 2026
@linear
Copy link

linear bot commented Feb 5, 2026

NES-1304 Media Layout

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jianweichong/nes-1304-media-layout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Feb 5, 2026

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit e4e7e3e

Command Status Duration Result
nx run journeys-admin-e2e:e2e ❌ Failed 4m 40s View ↗
nx run-many --target=vercel-alias --projects=jo... ✅ Succeeded 2s View ↗
nx run-many --target=upload-sourcemaps --projec... ✅ Succeeded 13s View ↗
nx run-many --target=deploy --projects=journeys... ✅ Succeeded 2m 42s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-05 03:50:15 UTC

@github-actions github-actions bot temporarily deployed to Preview - journeys-admin February 5, 2026 03:39 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready journeys-admin preview Thu Feb 5 16:43:09 NZDT 2026

@blacksmith-sh
Copy link
Contributor

blacksmith-sh bot commented Feb 5, 2026

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
src/smoke/create-journey.spec.ts/admin can create a journey View Logs

Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant