Conversation
ebeb6dd to
c58e7fd
Compare
|
I heard that your motivation is to solve the compatibily with modules such as These modules are using Xposed API 100, and a related bug is fixed in ed1f61d. Please also refer to #466 (comment) |
|
@JingMatrix No, my target was not PlayStrong module. I just tried to adapt the current API with all of new methods without killing the old version support. You can see it in the code, I didn't touched to anything about SELinux etc. and only tried to follow the new API requirements. |
|
Sorry for the confusion guys! This commit actually has 3 fixes:
2-3 Fixes the Play strong issue and 1 actually is the PR submitted by @frknkrc44 to support new APIs for modules like Hyper ceiler new versions (Not sure of this claim though). The PR here has nothing to do with Play Strong compatibility and is a standalone PR. |
|
@frknkrc44 oh, sorry, I must have closed this by accident (mis-click on the phone). When I get some time on adapting the upstream changes, I will tell you. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@frknkrc44 Your implements of APIs Your handling of annotation removal is However, the problem is the API change itself, not us. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@JingMatrix I only want to say:
|
|
Okay, I will credit you for the part we are using the same solution. |
|
@frknkrc44 1. The pull-request was closed by accident, probably a mis-click. |
|
@JingMatrix Thanks for force-push after crediting me, and I accept your apologize. |
It is an initial attempt and needs testing.