Patch for controllers/user.py

[beetle-ai]

The code was modified to check if temp_dir exists before attempting to use it in the finally block. This prevents a potential NameError if an exception occurs before temp_dir is assigned a value.Changes made:

• Replaced: except Exception as e: print(f"Resume upload error: {str(e)}") raise HTTPException(status_code=500, ...
• With: except Exception as e: print(f"Resume upload error: {str(e)}") raise HTTPException(status_code=500, ...

Related Issue: #N/A

File: controllers/user.py
Branch: fix/1759587030646-3b0317 → main

[beetle-ai]

🤖 CodeDetector Analysis

🧹 Ensure Temporary File Cleanup in upload_resume

File: controllers/user.py
Lines: 70-78
Severity: Medium

Problem

The upload_resume function creates temporary files during the resume processing. If an exception occurs during this process, these temporary files might not be deleted, leading to potential disk space issues and security concerns.

Current Code

except Exception as e:
print(f"Resume upload error: {str(e)}")
raise HTTPException(status_code=500, detail=str(e))

Suggested Fix

except Exception as e:
print(f"Resume upload error: {str(e)}")
raise HTTPException(status_code=500, detail=str(e))
finally:
# Cleanup temporary files
if temp_dir and os.path.exists(temp_dir):
for root, dirs, files in os.walk(temp_dir, topdown=False):
for name in files:
os.remove(os.path.join(root, name))
os.rmdir(root)

Why This Fix Works

• The finally block ensures that the temporary directory and its contents are always cleaned up, regardless of whether an exception occurs.
• This prevents potential disk space exhaustion and reduces the risk of sensitive data lingering in temporary files.

Additional Context

The os.walk function is used to recursively delete files and directories within the temporary directory. The topdown=False argument ensures that files are deleted before their parent directories.

---

Powered by CodeDetector - AI-powered code analysis