fix(lineWidth) center timeline when having different line width#7
Open
lidio601 wants to merge 3 commits intoJohan-dutoit:masterfrom
Open
fix(lineWidth) center timeline when having different line width#7lidio601 wants to merge 3 commits intoJohan-dutoit:masterfrom
lidio601 wants to merge 3 commits intoJohan-dutoit:masterfrom
Conversation
a00c5f3 to
ce7a0a9
Compare
Author
Owner
|
Hey, I'll take a look at this soon. |
Author
|
Hi @Johan-dutoit I've updated the PR with an extra parameter |
Author
|
@Johan-dutoit if you are interested in this one I can port this one to the 2.0 |
Owner
|
@lidio601 Definitely interested in this one. What's your thinking around it? perhaps making it a preset? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Use case:
When having different line width the timeline is not centered:
After this fix, it looks like this: