Attach event listeners to canvas whenever possible#112
Draft
catruge wants to merge 13 commits intoJonComo:masterfrom
Draft
Attach event listeners to canvas whenever possible#112catruge wants to merge 13 commits intoJonComo:masterfrom
catruge wants to merge 13 commits intoJonComo:masterfrom
Conversation
catruge
force-pushed
the
attach-events-to-canvas
branch
from
05884e0 to
ed599ae
Compare
catruge
force-pushed
the
attach-events-to-canvas
branch
from
04e523d to
f7d1288
Compare
catruge
force-pushed
the
attach-events-to-canvas
branch
2 times, most recently
from
03a9fd9 to
bbea6e2
Compare
catruge
force-pushed
the
attach-events-to-canvas
branch
from
853feee to
634e297
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. This pull request attaches event listeners in the setup code to the canvas element instead of the window element whenever possible. This hinders the listeners from interfering with the rest of the page and also removes the need to check whether the emitter of an event is indeed the canvas. Also, this pull request refactors the keyboard and mouse listeners to (hopefully) aid readability. However, I haven't tested the refactored code, so this pull request should not be merged yet.