Add tabs to info section below bingo table#151
Open
cvenencia wants to merge 2 commits intoJoshimuz:masterfrom
Open
Add tabs to info section below bingo table#151cvenencia wants to merge 2 commits intoJoshimuz:masterfrom
cvenencia wants to merge 2 commits intoJoshimuz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Josh said he wanted to put the information below the bingo table behind tabs so I did it. You can check out a live version using the tabs here.
The tabs implementation comes from Kevin Powell's video and codepen. I made small modifications just to make it work here.
You can navigate the tabs by either clicking on them, or focusing anywhere inside the
section#rules-sectionelement and pressing right or left arrow. I made sure this doesn't interfere with any of the current interactable elements inside for accessibility reasons.I added the tabs functionality to a new file (
tabs.js). Also tried to minimize the changes toindex.htmlto avoid possible merge conflicts by not indenting the sections that were already there, so indentation is a bit broken in the sections I updated.I can make further changes as required.