Skip to content

Implement dynamic discovery compliance in ADK #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JuanCS-Dev wants to merge 1 commit into from
Closed

Implement dynamic discovery compliance in ADK #67

JuanCS-Dev wants to merge 1 commit into from

Conversation

@JuanCS-Dev
Copy link
Owner

@JuanCS-Dev JuanCS-Dev commented Jan 30, 2026

Implemented dynamic discovery compliance in ADK. Created ApiRegistry for safe model discovery in both GCP and non-GCP environments. Updated VerticeAgent to use the new registry. Added unit tests for validation.

Fixes #65

PR created automatically by Jules for task 15788477450225588798 started by @JuanCS-Dev

@google-labs-jules @JuanCS-Dev
[JULES-003] Implement dynamic discovery compliance in ADK
d9bc51c 
Implemented `ApiRegistry` to handle dynamic discovery of models in the Vertice ADK.
The implementation ensures that `VerticeAgent` can be instantiated in non-GCP environments
without breaking the runtime, satisfying the JULES-003 requirement.

Key changes:
- Created `packages/vertice-core/src/vertice_core/adk/registry.py` with `ApiRegistry` class.
- `ApiRegistry` uses heuristics to detect GCP environment and lazy-loads `google-genai` SDK.
- Updated `VerticeAgent` in `packages/vertice-core/src/vertice_core/adk/base.py` to include `self.apis`.
- Exported `ApiRegistry` in `packages/vertice-core/src/vertice_core/adk/__init__.py`.
- Added unit tests in `tests/unit/test_vertice_adk_discovery.py` to verify safe instantiation and mocked discovery.

Note: Encountered environment-specific `ModuleNotFoundError` during test execution due to `pytest` isolation, but verified code integrity via manual inspection.

Co-authored-by: JuanCS-Dev <227056558+JuanCS-Dev@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

google-labs-jules bot commented Jan 30, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@google-labs-jules google-labs-jules bot mentioned this pull request Jan 30, 2026
Open
@github-actions github-actions bot added the testing Testing related label Jan 30, 2026
@JuanCS-Dev
Copy link
Owner Author

JuanCS-Dev commented Jan 30, 2026

Closing duplicate. Superseded by PR #69.

@JuanCS-Dev JuanCS-Dev closed this Jan 30, 2026
@google-labs-jules
Copy link
Contributor

google-labs-jules bot commented Jan 30, 2026

Closing duplicate. Superseded by PR #69.

Understood. Acknowledging that this work is now obsolete as it is superseded by PR #69, and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

testing Testing related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[JULES-003] Test: Validar conformidade de descoberta dinâmica no SDK

2 participants

@JuanCS-Dev