use pattern to handle a commands #144
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortov
reviewed
Apr 5, 2018
| while (true) { | ||
| String command = view.read(); | ||
| handler.handleCommand(command); | ||
| if (command.toLowerCase().equals("exit")) { |
There was a problem hiding this comment.
А зачем этот if, если есть команда exit?)
kortov
reviewed
Apr 5, 2018
|
|
||
| @Override | ||
| public void execute() { | ||
| if (databaseManager.hasConnection()) { |
There was a problem hiding this comment.
Я поэтому сделал 2 метода с коннектом и без, чтобы не городить if else в каждой команде)
kortov
reviewed
Apr 5, 2018
| } | ||
|
|
||
| public void handleCommand(String strCommand) { | ||
| if (strCommand.toLowerCase().equals("help")) { |
There was a problem hiding this comment.
Потом лучше, конечно, это в команду help вытащить)
kortov
reviewed
Apr 5, 2018
| } | ||
| } | ||
|
|
||
| private Command getCommandByName(String commandName) { |
There was a problem hiding this comment.
А я не могу понять как отрабатывает connect, если как enum это одно слово connect, а как команда он 4 слова
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.