Closed
Conversation
Co-authored-by: Pietro Vertechi <pietro.vertechi@protonmail.com>
Co-authored-by: Pietro Vertechi <pietro.vertechi@protonmail.com>
Co-authored-by: Pietro Vertechi <pietro.vertechi@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the changes of the other PR. It thus contains CUDA support.
In addition a new datatype
MutableShiftedArrayis added, which is essentially copy-paste of the code of theShiftedArraytype. However it supports thesetindex!function.An alternative could have been to simply add the
setindex!function to theShiftedArraytype, but this can potentially lead to backwards compatibility issues, which is why I opted for this version with another type.The CUDA Adapt methods of this new type are also supported and I added some tests for the mutatation operation.
Note that mutation of places hosting the
defaulttype, are silently ignored. Which is what the typical use-case would want. However, it does feel slightly odd and may lead to trouble for some code which relies on the fact that a mutation really changes a place and a subsequent read operation reflects this change.