Update to Julia package state of the art#33
Open
gnadt wants to merge 6 commits intoJuliaAudio:masterfrom
Open
Conversation
ssfrr
requested changes
Sep 10, 2025
Contributor
ssfrr
left a comment
ssfrr
left a comment
There was a problem hiding this comment.
mostly looks great, thanks! though what's the benefit of using TestItemRunner here? I'd rather not add a dependency unless there's a clear win, and in this case it seems like it adds an extra level of indirection.
Can you revert that and rebase on the lastest main?
Comment on lines
+8
to
+11
| inputs: | ||
| lookback: | ||
| default: "3" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ideally it could be registered now, addressing #23