The data field from SampleBuf and SpectrumBuf now accept `Abstr…#105
Open
pjabardo wants to merge 1 commit intoJuliaAudio:masterfrom
Open
The data field from SampleBuf and SpectrumBuf now accept `Abstr…#105pjabardo wants to merge 1 commit intoJuliaAudio:masterfrom
data field from SampleBuf and SpectrumBuf now accept `Abstr…#105pjabardo wants to merge 1 commit intoJuliaAudio:masterfrom
Conversation
…actArray` Used the approach used by `AxisArrays` where the a new parametric type is used to specify the array data type. The constructor is used to garantee that an `AbstractArray` is actually used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…actArray`
Used the approach used by
AxisArrayswhere the a new parametric type is used to specify the array data type. The constructor is used to garantee that anAbstractArrayis actually used.What does this implement/fix?
For now,
SampleBufPandSpectrumBufuse anArrayobject to store data. But using anAbstractArraycould be interesting, mostly for using views of arrays.There is an issue #60 that deals with it but the approach
uses abstract type for the
datafield which has several issues.The approach here, uses the same approach as
AxisArrayspacakge:Now, not only can
SubArraysbe used but other arrays types such asStaticArraysorFixedSizeArrayscan be used.Reference issue
Example: Fixes #60.
Additional information
Any additional information you think is important.