-
Notifications
You must be signed in to change notification settings - Fork 3
Parametric Generalized Hamiltonian Neural Networks #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
benedict-96
wants to merge
52
commits into
main
Choose a base branch
from
parametrized-hamiltonian-general-neural-networks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Parametric Generalized Hamiltonian Neural Networks #207
benedict-96
wants to merge
52
commits into
main
from
parametrized-hamiltonian-general-neural-networks
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ral_network.jl (ii) created generalized_hamiltonian_neural_network where I defined energy functions (iii) moved basic functionality form standard_hamiltonian_neural_network.jl to new file hamiltonian_neural_network.jl.
…ithout data loader).
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 61.82% 59.42% -2.40%
==========================================
Files 124 132 +8
Lines 3790 4222 +432
==========================================
+ Hits 2343 2509 +166
- Misses 1447 1713 +266 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e body of the function.
…make this work now.
…I also removed the ubiquitous warning messages observalbe before.
…broadcasting for bias vector).
…grator from Marsden-West.
…s as default when network was agnostic to Q/P.
… sublayers in a forcing layers, which should be independent of the total number of layers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented PGHNNs.
Things that should probably be done before this pr is merged:
applychain, the method for functor ofChainandJacobian) in filegeneralized_hamiltonian_neural_network.jl,QPT2inAbstractNeuralNetworksand ultimately get rid of whatQPTis now,DataLoaderto the parameter-dependent scenario.