Skip to content

[SPIRVIntrinsics] Subgroup shuffle and barrier intrinsics#418

Closed
christiangnrd wants to merge 2 commits intomasterfrom
subgroupintr
Closed

[SPIRVIntrinsics] Subgroup shuffle and barrier intrinsics#418
christiangnrd wants to merge 2 commits intomasterfrom
subgroupintr

Conversation

@christiangnrd
Copy link
Member

@christiangnrd christiangnrd commented Feb 13, 2026

Easier to review than #413 and then we can release SPIRVIntrinsics.jl 0.5.7 and remove the temporary compat workarounds in the oneAPI, OpenCL, and KA POCL backend branches.

christiangnrd and others added 2 commits February 13, 2026 18:50
Co-Authored-By: Simeon David Schaub <simeon@schaub.rocks>
@github-actions
Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/lib/intrinsics/src/synchronization.jl b/lib/intrinsics/src/synchronization.jl
index 7d88b69..c8abe6d 100644
--- a/lib/intrinsics/src/synchronization.jl
+++ b/lib/intrinsics/src/synchronization.jl
@@ -156,7 +156,9 @@ export barrier, work_group_barrier, sub_group_barrier
                     MemorySemantics.SequentiallyConsistent | mem_fence_flags_to_semantics(flags))
 
 @inline sub_group_barrier(flags, scope = memory_scope_sub_group) =
-    control_barrier(Scope.Subgroup, cl_scope_to_spirv(scope),
-                    MemorySemantics.SequentiallyConsistent | mem_fence_flags_to_semantics(flags))
+    control_barrier(
+    Scope.Subgroup, cl_scope_to_spirv(scope),
+    MemorySemantics.SequentiallyConsistent | mem_fence_flags_to_semantics(flags)
+)
 
 barrier(flags) = work_group_barrier(flags)

@simeonschaub
Copy link
Member

What's the reason we can't just merge this together with the OpenCL.jl changes in #413? I am a little weary of merging this without its tests

@christiangnrd
Copy link
Member Author

What's the reason we can't just merge this together with the OpenCL.jl changes in #413? I am a little weary of merging this without its tests

The main reason was that this is useful on its own for other packages, so I was hoping that splitting it up would make it easier for a reviewer to find the time.

I’ll address the comments in #413 directly and close this once #413 is merged.

@christiangnrd christiangnrd deleted the subgroupintr branch February 18, 2026 18:35
@christiangnrd christiangnrd restored the subgroupintr branch February 18, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments