[SPIRVIntrinsics] Subgroup shuffle and barrier intrinsics#418
Closed
christiangnrd wants to merge 2 commits intomasterfrom
Closed
[SPIRVIntrinsics] Subgroup shuffle and barrier intrinsics#418christiangnrd wants to merge 2 commits intomasterfrom
christiangnrd wants to merge 2 commits intomasterfrom
Conversation
Co-Authored-By: Simeon David Schaub <simeon@schaub.rocks>
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/lib/intrinsics/src/synchronization.jl b/lib/intrinsics/src/synchronization.jl
index 7d88b69..c8abe6d 100644
--- a/lib/intrinsics/src/synchronization.jl
+++ b/lib/intrinsics/src/synchronization.jl
@@ -156,7 +156,9 @@ export barrier, work_group_barrier, sub_group_barrier
MemorySemantics.SequentiallyConsistent | mem_fence_flags_to_semantics(flags))
@inline sub_group_barrier(flags, scope = memory_scope_sub_group) =
- control_barrier(Scope.Subgroup, cl_scope_to_spirv(scope),
- MemorySemantics.SequentiallyConsistent | mem_fence_flags_to_semantics(flags))
+ control_barrier(
+ Scope.Subgroup, cl_scope_to_spirv(scope),
+ MemorySemantics.SequentiallyConsistent | mem_fence_flags_to_semantics(flags)
+)
barrier(flags) = work_group_barrier(flags) |
Member
|
What's the reason we can't just merge this together with the OpenCL.jl changes in #413? I am a little weary of merging this without its tests |
Member
Author
The main reason was that this is useful on its own for other packages, so I was hoping that splitting it up would make it easier for a reviewer to find the time. I’ll address the comments in #413 directly and close this once #413 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easier to review than #413 and then we can release SPIRVIntrinsics.jl 0.5.7 and remove the temporary compat workarounds in the oneAPI, OpenCL, and KA POCL backend branches.