Open
Conversation
added 2 commits
February 27, 2023 14:54
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 52 52
Lines 1374 1374
=======================================
Hits 1295 1295
Misses 79 79 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
|
@mjp98 if you could confirm that this seems to fix things on your end, I'll merge |
theogf
approved these changes
Apr 11, 2023
devmotion
reviewed
Aug 17, 2023
Comment on lines
+18
to
+20
| @test isapprox( | ||
| kernelmatrix(k, x, y), kernelmatrix(k, collect(x), collect(y)); rtol=1e-6 | ||
| ) |
Member
There was a problem hiding this comment.
Is the non-standard rtol needed, in particular if we fix the seeds with StableRNGs? Maybe
Suggested change
| @test isapprox( | |
| kernelmatrix(k, x, y), kernelmatrix(k, collect(x), collect(y)); rtol=1e-6 | |
| ) | |
| @test kernelmatrix(k, x, y) ≈ kernelmatrix(k, collect(x), collect(y)) |
would be sufficient?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces an equality test with an approximate equality test to handle roundoff issues. Should resolve #494
Proposed changes
Loosen a test tolerance very slightly
What alternatives have you considered?
None
Breaking changes
None