Update check_zygote_type_stability()...#568
Merged
theogf merged 1 commit intoJuliaGaussianProcesses:tgf/flexible-testsfrom Mar 5, 2025
gnadt:patch-1
Merged
Update check_zygote_type_stability()...#568theogf merged 1 commit intoJuliaGaussianProcesses:tgf/flexible-testsfrom gnadt:patch-1
theogf merged 1 commit intoJuliaGaussianProcesses:tgf/flexible-testsfrom
gnadt:patch-1
Conversation
so that CI passes with Julia v1.10. Tested locally with Julia v1.10 & v1.11. Forces the expected type to be `Vector{Union{Nothing, @NamedTuple{X::Matrix{Float64}}}}` which is more robust for different package versions. There may be better solutions, but this seems to work.
Contributor
Author
|
The docs build failure is addressed in #566 |
Member
|
I think it's a shame that we need to do this, but if @theogf is happy for it to be merged into his branch, I'm also happy for it to go in, as the lack of robustness of our AD tests is a real problem. |
Member
|
Ah sorry, I did not realize you were targeting my branch... |
theogf
merged commit 6e7d2be
into
JuliaGaussianProcesses:tgf/flexible-tests
23 of 25 checks passed
theogf
added a commit
that referenced
this pull request
Mar 5, 2025
* make allocs tests easier * replace nightly by lts * move Zygote to broken with ReverseDiff * Update check_zygote_type_stability()... (#568) so that CI passes with Julia v1.10. Tested locally with Julia v1.10 & v1.11. Forces the expected type to be `Vector{Union{Nothing, @NamedTuple{X::Matrix{Float64}}}}` which is more robust for different package versions. There may be better solutions, but this seems to work. --------- Co-authored-by: Albert R. Gnadt <20693045+gnadt@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## tgf/flexible-tests #568 +/- ##
=======================================================
+ Coverage 0.28% 48.89% +48.61%
=======================================================
Files 52 52
Lines 1421 1446 +25
=======================================================
+ Hits 4 707 +703
+ Misses 1417 739 -678 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that CI passes with Julia v1.10. Tested locally with Julia v1.10 & v1.11. Forces the expected type to be
Vector{Union{Nothing, @NamedTuple{X::Matrix{Float64}}}}which is more robust for different package versions. There may be better solutions, but this seems to work.