Skip to content

New package: TrustRegionReflective v0.4.2#149575

Open
JuliaRegistrator wants to merge 1 commit intomasterfrom
registrator-trustregionreflective-b2fb89f2-v0.4.2-a21288d0f1
Open

New package: TrustRegionReflective v0.4.2#149575
JuliaRegistrator wants to merge 1 commit intomasterfrom
registrator-trustregionreflective-b2fb89f2-v0.4.2-a21288d0f1

Conversation

@JuliaRegistrator
Copy link
Contributor

- Match scipy version better
- Test type stability

UUID: b2fb89f2-9639-4e52-b458-b5e2ad6f229e
Repo: https://github.com/oscarvanderheide/TrustRegionReflective.jl.git
Tree: e299c436a05369a8a9deca65dd854a46f0f90642

Registrator tree SHA: 50f504d641745716a5b3eabaf681d3a4937d2ae3
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Mar 2, 2026

It is now a separate package but has not been tested outside of the scope of the larger codebase. Use at your own risk.

Since registered packages are intended to be useful to a wide audience, I would ask that you add some tests before continuing with the registration. Just refactoring out some piece of code and then "throwing it over the wall" without any further checks that it works correctly and is useable is less than ideal

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Mar 2, 2026
@oscarvanderheide
Copy link

It was an outdated comment that has now been removed. The package contains tests of the solver being run on some (common) toy examples that run successfully.

@goerz
Copy link
Member

goerz commented Mar 2, 2026

Great, looks good then!

It would probably be a good idea to set up the typical .github/workflows/CI.yml to run the tests automatically.

[noblock]

@goerz goerz added the Override AutoMerge: ignore blocking comments Instructs automerge to ignore blocking comments label Mar 2, 2026
@JuliaTagBot JuliaTagBot removed the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new package Override AutoMerge: ignore blocking comments Instructs automerge to ignore blocking comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants