Honor Registrator branch when creating releases #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
arnavk23
commented
Jan 9, 2026
arnavk23
commented
- Extract release branch from registry PR body (Registrator [branch=]) and prioritize it over config/default when creating releases.
- Thread version through release-branch helpers so per-version branch selection works.
- Add tests for branch parsing/priority and update release tests to avoid network calls.
- Fixes Look up release branch in commit comment #200
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances TagBot to honor the branch specification from Registrator when creating releases. The implementation extracts the branch information from the registry PR body and prioritizes it over the configured or default branch.
Key changes:
- Converts
_release_branchfrom a property to a method that accepts a version parameter, enabling per-version branch selection - Adds
_branch_from_registry_pr()method to parse branch information from registry PR body using regex - Updates all call sites to thread version information through the release-branch helpers
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tagbot/action/repo.py | Implements branch extraction from registry PR body, converts _release_branch to version-aware method, and updates all dependent methods |
| test/action/test_repo.py | Adds comprehensive tests for branch parsing logic and updates existing tests to pass version parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
@IanButterworth whenever you are free, please take a look. Thanks! |
Member
|
Claude found some issues. Do you mind if I push? |
Collaborator
Author
No issues. Do push changes. |
…tion, dedupe calls - Tighten _branch_from_registry_pr regex to require dash prefix (Registrator format) - Narrow except Exception to (GithubException, RequestException) in _release_branch - Inline _commit_sha_of_release_branch in create_release to avoid double _release_branch() call - Add pr.body None check in _commit_sha_from_registry_pr for consistency - Update tests accordingly Co-authored-by: Claude <noreply@anthropic.com>
IanButterworth
approved these changes
Feb 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.