Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 86.61% 87.93% +1.31%
==========================================
Files 36 36
Lines 3901 4077 +176
==========================================
+ Hits 3379 3585 +206
+ Misses 522 492 -30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c68189d to
8525cbd
Compare
|
Ok, I think I am happy with the implementation now from my side. This should enable some initial experimentation with symplectic Gram-Schmidt methods. Future work might include blocked methods such as described in https://journal.austms.org.au/ojs/index.php/ANZIAMJ/article/view/9380/1920, but I don't want to make this PR much bigger than it already is. |
|
Ok, I will have to study this a bit further and let it sink in, but my initial impression is that I am not a big fan of "recycling" |
See the discussion in #150. On my test case, this already gives me
significantly better performance, and improved accuracy, if using
re-skew-orthogonalization, than my hand-rolled Arnoldi implementation. An initial sketch was written by Copilot, but
I revised and reviewed the result extensively.
closes #150