feat: Add daily build support for JS and Rust bindings #11
Conversation
- Add triggers for schedule (daily) and push to all branches in `mnn_release.yml`. - Add `js-release` job to run `npm pack` with daily versioning. - Add `rust-release` job to run `cargo build --release` with daily versioning, depending on linux build. - Update `upload-release` to include JS and Rust artifacts and handle moving `nightly` tag. - Ensure proper artifact downloading and packaging.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Update the `sed` command in the `rust-release` job to use double quotes with escaped inner double quotes. - This fixes a syntax error "unexpected EOF while looking for matching `''`" caused by complex single-quote concatenation in bash when updating the Cargo.toml version. - Verified that `js-release` continues to work as expected. - No changes to other jobs.
- Use softprops/action-gh-release for reliable release creation. - Implement separate daily releases with `nightly-YYYYMMDD` tags. - Correct artifact path handling to ensure assets are uploaded. - Ensure proper dependency on setup job for version variable access.
This PR updates the
.github/workflows/mnn_release.ymlworkflow to support continuous integration and daily release builds for the JS and Rust bindings.Key changes:
schedule(cron: 0 0 * * ) andpush(branches: '') triggers to the workflow.YYYYMMDD) for non-tag builds.js-releasejob that packages the JS binding (npm pack) with a nightly version tag.rust-releasejob that downloads the compiled MNN core fromlinux-release, builds the Rust binding (cargo build --release) with a nightly version tag, and packages the result (binaries + libMNN) into a zip.upload-releasejob to collect the new artifacts and publish them to the release (targeting thenightlytag for daily builds).rust-releasejob correctly finds and links against thelibMNN.soartifact from the linux build.PR created automatically by Jules for task 4900446765729644895 started by @Juude