Support building mnncli on Linux #4
Conversation
- Modified `apps/mnncli/build.sh` to auto-detect OS and adjust CMake flags. - Updated `apps/mnncli/CMakeLists.txt` to find OpenSSL on Linux. - Fixed `transformers/diffusion/engine/src/tokenizer.hpp` missing include for Linux compilation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Modified `apps/mnncli/build.sh` to auto-detect OS and adjust CMake flags. - Added `-DLLM_SUPPORT_HTTP_RESOURCE=OFF` to build flags to fix threading crash on Linux. - Updated `apps/mnncli/CMakeLists.txt` to find OpenSSL on Linux. - Fixed `transformers/diffusion/engine/src/tokenizer.hpp` missing include for Linux compilation.
- Modified `apps/mnncli/build.sh` to auto-detect OS and adjust CMake flags. - Added `-DLLM_SUPPORT_HTTP_RESOURCE=OFF` to build flags to fix threading crash on Linux. - Updated `apps/mnncli/CMakeLists.txt` to find OpenSSL on Linux. - Fixed `transformers/diffusion/engine/src/tokenizer.hpp` missing include for Linux compilation. - Updated `apps/mnncli/README.md` with Linux build note.
This PR updates the mnncli build system to support Linux environments.
It modifies
build.shto detect the operating system and apply appropriate CMake flags (disabling Metal on Linux, handling OpenSSL).It also fixes a compilation error in
tokenizer.hppby including<cstdint>.Verified the build and model execution on Linux. Note that
mnncli downloadcurrently has a known issue on Linux related to threading/mutex, but execution works with manually downloaded models.PR created automatically by Jules for task 1468759839829722142 started by @Juude