Minor Change in Parameter Extraction on Parameters on CFFParser#58
Open
nogueiravinicius wants to merge 2 commits intoKCL-Planning:masterfrom
Open
Minor Change in Parameter Extraction on Parameters on CFFParser#58nogueiravinicius wants to merge 2 commits intoKCL-Planning:masterfrom
nogueiravinicius wants to merge 2 commits intoKCL-Planning:masterfrom
Conversation
This is a minor modification to the CFFPlanParser to include more general cases covered by PDDL 2.1. The planner was able to give a valid plan but the parser would not work correctly. The earliest version identifies the predicate by locating its type. So it always should have a type after every predicate, in other to work. For example it would work in: :parameters (?q - robot ?wayp - waypoint ?wayp2 - waypoint ) But not in: :parameters (?q - robot ?wayp ?wayp2 - waypoint ) or :parameters (?q ?wayp ?wayp2) The proposed version uses the same original structure but identify the predicate by locating the "?"
nogueiravinicius
changed the title
This is a minor modification to the CFFPlanParser to include more general cases covered by PDDL 2.1. The planner was able to give a valid plan but the parser would not work correctly. The earliest version identifies the parameter by locating its type. So it always should have a type after every parameter, in other to work. For example it would work in: :parameters (?q - robot ?wayp - waypoint ?wayp2 - waypoint ) But not in: :parameters (?q - robot ?wayp ?wayp2 - waypoint ) or :parameters (?q ?wayp ?wayp2) The proposed version uses the same original structure but identify the parameter by locating the "?"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor modification to the CFFPlanParser to include more general cases covered by PDDL 2.1. The planner was able to give a valid plan but the parser would not work correctly. The earliest version identifies the parameter by locating its type. So it always should have a type after every parameter, in other to work.
For example it would work in:
:parameters (?q - robot ?wayp - waypoint ?wayp2 - waypoint )
But not in:
:parameters (?q - robot ?wayp ?wayp2 - waypoint ) or :parameters (?q ?wayp ?wayp2)
The proposed version uses the same original structure but identify the parameter by locating the "?"