Skip to content

Fix inverted maintenance button labels in admin dashboard #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skerbis merged 2 commits into from
Nov 10, 2025
Merged

Fix inverted maintenance button labels in admin dashboard #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6980d8
Initial plan
Copilot Nov 10, 2025
c85de21
Fix maintenance button labels - correct logic and use translation keys
Copilot Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pages/dashboard_admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ function getThreatsByCountry() {
<input type="hidden" name="toggle_action" value="toggle_frontend">
<button type="submit" class="btn btn-sm <?= $frontendMaintenanceActive ? 'btn-success' : 'btn-warning' ?>">
<i class="rex-icon fa-<?= $frontendMaintenanceActive ? 'play' : 'pause' ?>"></i>
Comment on lines 343 to 344
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button styling and icon logic appear to be inverted. When maintenance is active, the button shows green (btn-success) with a "play" icon, but this is inconsistent with the "Deactivate" text on line 345.

For consistency with other parts of the codebase (e.g., pages/mail_security.badwords.php line 553-554), when maintenance is active, it should show:

  • btn-warning (yellow/orange)
  • fa-pause icon
  • "Deactivate" text

Suggested fix:

<button type="submit" class="btn btn-sm <?= $frontendMaintenanceActive ? 'btn-warning' : 'btn-success' ?>">
    <i class="rex-icon fa-<?= $frontendMaintenanceActive ? 'pause' : 'play' ?>"></i>
Suggested change
<button type="submit" class="btn btn-sm <?= $frontendMaintenanceActive ? 'btn-success' : 'btn-warning' ?>">
<i class="rex-icon fa-<?= $frontendMaintenanceActive ? 'play' : 'pause' ?>"></i>
<button type="submit" class="btn btn-sm <?= $frontendMaintenanceActive ? 'btn-warning' : 'btn-success' ?>">
<i class="rex-icon fa-<?= $frontendMaintenanceActive ? 'pause' : 'play' ?>"></i>

Copilot uses AI. Check for mistakes.
<?= $frontendMaintenanceActive ? 'Aktivieren' : 'Wartung' ?>
<?= $frontendMaintenanceActive ? $addon->i18n('upkeep_deactivate') : $addon->i18n('upkeep_activate') ?>
</button>
</form>
<?php endif; ?>
Expand Down Expand Up @@ -397,7 +397,7 @@ function getThreatsByCountry() {
<input type="hidden" name="toggle_action" value="toggle_backend">
<button type="submit" class="btn btn-sm <?= $backendMaintenanceActive ? 'btn-success' : 'btn-warning' ?>">
<i class="rex-icon fa-<?= $backendMaintenanceActive ? 'play' : 'pause' ?>"></i>
Comment on lines 398 to 399
Copy link

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button styling and icon logic appear to be inverted. When maintenance is active, the button shows green (btn-success) with a "play" icon, but this is inconsistent with the "Deactivate" text on line 400.

For consistency with other parts of the codebase (e.g., pages/mail_security.badwords.php line 553-554), when maintenance is active, it should show:

  • btn-warning (yellow/orange)
  • fa-pause icon
  • "Deactivate" text

Suggested fix:

<button type="submit" class="btn btn-sm <?= $backendMaintenanceActive ? 'btn-warning' : 'btn-success' ?>">
    <i class="rex-icon fa-<?= $backendMaintenanceActive ? 'pause' : 'play' ?>"></i>
Suggested change
<button type="submit" class="btn btn-sm <?= $backendMaintenanceActive ? 'btn-success' : 'btn-warning' ?>">
<i class="rex-icon fa-<?= $backendMaintenanceActive ? 'play' : 'pause' ?>"></i>
<button type="submit" class="btn btn-sm <?= $backendMaintenanceActive ? 'btn-warning' : 'btn-success' ?>">
<i class="rex-icon fa-<?= $backendMaintenanceActive ? 'pause' : 'play' ?>"></i>

Copilot uses AI. Check for mistakes.
<?= $backendMaintenanceActive ? 'Aktivieren' : 'Wartung' ?>
<?= $backendMaintenanceActive ? $addon->i18n('upkeep_deactivate') : $addon->i18n('upkeep_activate') ?>
</button>
</form>
<?php endif; ?>
Expand Down