fix: prevent crash when /locations returns empty object

[Skomorac]

The https://speed.cloudflare.com/locations endpoint currently returns an empty object {} instead of an array of locations. This was causing a TypeError: res.reduce is not a function because the code expected an array.

Changes:

Added a check using Array.isArray() to ensure the response is an array before calling .reduce().
Added a fallback in
fetchServerLocationData
to return an empty object if the response is invalid.
Improved the UI output to display only the airport code (colo) if the city name is not available.

[gemini-code-assist]

Summary of Changes

Hello @Skomorac, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the robustness and user experience of the application by addressing potential issues with external API responses. It introduces defensive programming practices to handle unexpected data formats from the /locations endpoint, preventing application crashes and ensuring a more graceful degradation of information display when complete data is unavailable.

Highlights

• Robust API Response Handling: Implemented checks to prevent crashes when the /locations endpoint returns an empty object instead of an expected array, specifically addressing a TypeError when calling .reduce() on a non-array.
• Improved Data Validation: Added Array.isArray() validation to ensure the parsed JSON response from /locations is indeed an array before further processing.
• Error Fallback Mechanism: Introduced a try-catch block for JSON.parse() and a fallback to return an empty object if the API response is invalid or parsing fails.
• Enhanced UI Output: Modified the display logic for server location to show only the airport code (colo) if the city name is not available, improving user experience in edge cases.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses a crash caused by an unexpected API response from the /locations endpoint. The added checks for JSON parsing and array type are robust. The UI fallback for the server location is also a good improvement. I've added a couple of suggestions to include logging for the error conditions you've handled. This will improve diagnostics and maintainability by making it easier to spot when the API is misbehaving, which aligns with practices elsewhere in the codebase.