Issue #22. Implement reading and sending to rpi imu data #24
Conversation
|
Hi, @taketook34 , I've tested new version of code with RPI, everything looks good to me, here are the logs: |
|
Good afternoon, please do not merge this pull request. I have met some mistakes and I need to fix them or verify why I met this |
|
@ChVictoria good day, please review this. Thank you |
Hello, I've made changes to bind UDP and TCP sockets to the same port and tested your update - everything works correct, thanks. |
|
Please fix the wollowing Code Style warnings: /__w/ecu_sw_bb/ecu_sw_bb/src/kpi_rover_ecu/src/KPIRoverECU.cpp:17:26: warning: no header providing "IMUController" is directly included [misc-include-cleaner] [2] /__w/ecu_sw_bb/ecu_sw_bb/src/kpi_rover_ecu/src/KPIRoverECU.cpp:66:18: warning: no header providing "size_t" is directly included [misc-include-cleaner] |
AksonovSergei
left a comment
AksonovSergei
left a comment
There was a problem hiding this comment.
Please double check that you use English language in comments.
src/kpi_rover_ecu/include/IClient.h
Outdated
| IClient& operator=(IClient&&) = delete; | ||
| }; | ||
|
|
||
| #endif No newline at end of file |
There was a problem hiding this comment.
Please add new line at the end
| int Init() override; | ||
| void Destroy() override; | ||
|
|
||
| std::string GetSourceIp(); |
There was a problem hiding this comment.
Please rename to GetClientIp() and GetClientPort()
| EXPECT_CALL(GetMockRCMPU(), read_accel(::testing::_)).WillOnce(::testing::Return(0)); | ||
| EXPECT_CALL(GetMockRCMPU(), read_gyro(::testing::_)).WillOnce(::testing::Return(0)); | ||
|
|
||
| // Получение данных |
There was a problem hiding this comment.
Please translate to English
|
|
||
| int rc_mpu_power_off(void) { | ||
| GetMockRCMPU().power_off(); | ||
| return 0; // Возвращаем успешный код |
| // Реализация rc_mpu_default_config | ||
| rc_mpu_config_t rc_mpu_default_config(void) { | ||
| rc_mpu_config_t config = {}; | ||
| config.i2c_bus = 2; // Настройка I2C шины |
| TEST_F(IMUControllerTest, GetDataWhenEnabled) { | ||
| imu_controller.SetEnable(); | ||
|
|
||
| // Настройка моков для чтения данных акселерометра, гироскопа, кватернионов |
| // Получение данных | ||
| std::vector<float> data = imu_controller.GetData(); | ||
|
|
||
| // Проверка того, что данные возвращены |
It should be fixed |
|
I hope it is all I need to fix. @AksonovSergei, please check |
Merging reading and sending data from IMU. Tests was written to new file.
It will be good if @ChVictoria verify last commit. I have tested before pr but not with RPI.