Skip to content

Conversation

@Fastroof
Copy link
Contributor

No description provided.

…ed for improved performance on curve paths and turns (#10)
@Fastroof Fastroof linked an issue Feb 19, 2025 that may be closed by this pull request
Copy link
Member

@AksonovSergei AksonovSergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Merging the main branch into the dev branch is not a common approach. It’s better to rebase.
  2. To approve this PR, I need to go through all the changes myself, which requires more time.
  3. @ChVictoria Please check if there are any conflicts with your changes.
  4. First, we will merge @ChVictoria's branch, and then I will apply your changes. For the first time, I will do most of the fixes myself. That’s okay.

Copy link
Contributor

@ChVictoria ChVictoria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the conflicts, that I've noticed so far:

  1. Everywhere in my code base_link_frame is base_footprint.

  2. I also use EKF node for SLAM, but it is almost identical to @Fastroof's ekf_filter_node_odom, so can be replaced with. For this the following changes should be done:

    • I use the /odometry/filtered topic for navigation, that should be replaced by /odometry/local.

    • In my case for IMU data /imu topic is used, while @Fastroof uses /imu/data.

  3. I've slightly changed robot description, so this changes also have to be merged.

So, someone should manually review all the changes and resolve the conflicts.

@Fastroof Fastroof closed this Feb 28, 2025
@Fastroof Fastroof reopened this Mar 10, 2025
@Fastroof Fastroof force-pushed the 10-gps-navigation branch from dd620a8 to 351b1e5 Compare March 10, 2025 12:13
## Install Required Packages

```bash
sudo apt install ros-jazzy-navigation2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These packages should be in package.xml and installed with rosdep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GPS navigation

4 participants