Kpmp 6370 use guest collection

[zwright]

Summary by CodeRabbit

• Documentation
  • Updated credential setup instructions to use Globus authentication instead of Google Drive.
  • Added Globus application registration guidance and updated credential workflow steps.
  • Improved localhost URL handling documentation.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The pull request transitions credential authentication documentation from Google Drive to Globus and refactors GlobusService to use root-relative paths instead of environment-configured directory references. The service now derives endpoint ID directly from environment properties during construction.

Changes

Cohort / File(s)	Summary
Documentation README.md	Replaced Google Drive credential setup instructions with Globus application registration and credential workflow, including steps for token deletion, service restart, URL retrieval, and localhost URL handling (127.0.0.1).
Globus Service Refactoring src/main/java/org/kpmp/globus/GlobusService.java	Removed @Value annotation from endpointID field and eliminated stored Environment field. Modified path construction in createDirectory(), getTopDirectory(), and getFilesAndDirectoriesAtEndpoint() to use root-relative paths ("/" + parameter) instead of environment-configured GLOBUS_DIR. Endpoint ID now initialized from env.getProperty("GLOBUS_ENDPOINT_ID") in constructor.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

README.md (1)

21-21: Format the URL according to markdown best practices.

The bare URL should be wrapped in angle brackets or converted to a proper markdown link.

📝 Proposed formatting options

Option 1 - Angle brackets:

-This application is registered in Globus here -- https://app.globus.org/ -- in the "KPMP Data Lake" project as "KPMP Data Lake Uploader". The application has the roles of the users assigned to it under the "Roles" tab. 
+This application is registered in Globus here -- <https://app.globus.org/> -- in the "KPMP Data Lake" project as "KPMP Data Lake Uploader". The application has the roles of the users assigned to it under the "Roles" tab.

Option 2 - Markdown link:

-This application is registered in Globus here -- https://app.globus.org/ -- in the "KPMP Data Lake" project as "KPMP Data Lake Uploader". The application has the roles of the users assigned to it under the "Roles" tab. 
+This application is registered in [Globus](https://app.globus.org/) in the "KPMP Data Lake" project as "KPMP Data Lake Uploader". The application has the roles of the users assigned to it under the "Roles" tab.

Based on static analysis hints.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6deb934 and 3587bf5.

📒 Files selected for processing (2)

• README.md
• src/main/java/org/kpmp/globus/GlobusService.java

🧰 Additional context used

🪛 markdownlint-cli2 (0.18.1)

README.md

21-21: Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (2)

README.md (1)

20-29: LGTM! Documentation accurately reflects the Globus credential workflow.

The updated documentation clearly outlines the Globus application registration and credential setup process, providing actionable steps for developers.

src/main/java/org/kpmp/globus/GlobusService.java (1)

47-47: No action needed: GLOBUS_DIR is not configured or used in production code.

GLOBUS_DIR does not appear in any configuration files (properties, yaml) and is not referenced in the production code. The current implementation exclusively uses root-relative paths ("/" + dirName). The only reference to GLOBUS_DIR is a unused mock setup in the test file, which appears to be leftover code. If GLOBUS_DIR was previously used, it was removed in an earlier change—this change does not involve its removal.

Likely an incorrect or invalid review comment.