Fix des positions des secteurs #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n SVG le secteur plutôt qu'en HTML
TefDesign
commented
Jun 20, 2024
| if (allGroupsSectors.length === countGroupsSectors) { | ||
| e.target.closest("g").classList.add('active') | ||
| } | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
Pour info @Kern046 j'ai fais en JS vanilla et pas JQuery car l'ajout ou de suppressions de classes ne fonctionne pas en jquery sur l'intérieur des SVG.
Collaborator
There was a problem hiding this comment.
T'as raison on va dégager Jquery dès qu'on peut !
TefDesign
commented
Jun 20, 2024
| } | ||
| g.active polygon, g.active polygon:hover { | ||
| fill: #1b9448 !important; | ||
| stroke: #34bf68 !important; |
Collaborator
Author
There was a problem hiding this comment.
Les !important étaient malheureusement inévitable. Quand je simplifierais le code, je pense qu'il y aura un clean à faire.
TefDesign
commented
Jun 20, 2024
|
|
||
| return ['left' => $cx, 'top' => $cy]; | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
@Kern046 purée merci ChatGPT car je n'aurais pas été capable de le faire. Si on peut la simplifier etc je te laisse voir :)
Kern046
force-pushed
the
feature/doctrine-orm
branch
4 times, most recently
from
3b77ec1 to
e9bcda3
Compare
Base automatically changed from
feature/doctrine-orm
to
feature/remove-daemon-server
August 3, 2024 07:30
Kern046
force-pushed
the
feature/remove-daemon-server
branch
from
2ba56b3 to
0896301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test sur toutes les factions
A noter :
@Kern046 la partie PHP de calcul du centre d'un polygon je ne sais pas faire seul. Je me suis aidé de ChatGPT pour créer la fonction de centrage (Et oui...). Mais si besoin :
https://math.stackexchange.com/questions/1362526/finding-center-of-convex-polygon
Avant :
Après :
