Conversation
183eb87 to
9a04338
Compare
…itask # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
@mducducd Please add tests. We should also do some end-to-end tests to validate TICON works. |
|
feature_extractor test takes all extractors in ExtractorName collection. STAMP/src/stamp/preprocessing/config.py Line 14 in 16d38d1 I rerun extractor test and all 17 extractors was tested including Ticon (h_optimus_1 integrated). I am not sure the run checks showed on github, virchow family are also missing. |
| """Align vir2 features to ctp features based on coordinates.""" | ||
| ref = np.round(np.asarray(ref_coords_um, dtype=np.float64), decimals) | ||
| oth = np.round(np.asarray(other_coords_um, dtype=np.float64), decimals) | ||
|
|
There was a problem hiding this comment.
please add some more comments on what is happening here
| @@ -0,0 +1,730 @@ | |||
| import math | |||
There was a problem hiding this comment.
please reference the preprint and github repo where we adapted this from
There was a problem hiding this comment.
We maybe should / need to do this for all encoders / models that we use / adapt from.. they usually also come with licenses.. but I think a proper reference should do it for now. Would be best at beginning of the specific file (additionally summarized at end of readme or getting started guide)
Uh oh!
There was an error while loading. Please reload this page.