Add missing percentPlayed field to onPlayBackEnded events#7
Open
HumorBaby wants to merge 1 commit intoKenV99:masterfrom
Open
Add missing percentPlayed field to onPlayBackEnded events#7HumorBaby wants to merge 1 commit intoKenV99:masterfrom
percentPlayed field to onPlayBackEnded events#7HumorBaby wants to merge 1 commit intoKenV99:masterfrom
Conversation
The `onPlayBackEnded` needed to specify that `percentPlayed` was a valid substitution field.
percentPlayed field to onPlayBackEnded eventspercentPlayed field to onPlayBackEnded events
|
Will this fix the fact add-on isn’t working in Leia at all? :( |
pikim
added a commit
to pikim/script.service.kodi.callbacks
that referenced
this pull request
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
onPlayBackEndedneeded to specify thatpercentPlayedwas a validsubstitution field.
The event allows for (and even provides in the example) a field for
percentPlayed:script.service.kodi.callbacks/resources/lib/events.py
Lines 43 to 47 in d5dfb0e
yet, this field is never substituted in args.
I used
%ppas the two-letter field name despite there already being another%ppforprofilePath. These two fields should never collide, so I figured it was okay to do this.