added </option> as an optional ommited end tag#417
Closed
pollei wants to merge 1 commit intoKhan:masterfrom
Closed
added </option> as an optional ommited end tag#417pollei wants to merge 1 commit intoKhan:masterfrom
pollei wants to merge 1 commit intoKhan:masterfrom
Conversation
as per http://www.w3.org/TR/html5/syntax.html#optional-tags updated README to deal with some link-rot modified: external/slowparse/README.md modified: external/slowparse/slowparse.js https://www.khanacademy.org/profile/spollei/
Contributor
There was a problem hiding this comment.
Shouldn't "tr", "rb", "rt", "rtc", "rp", "optgroup", "thead", "tbody" and "tfoot" also be added to ombittableCloeTagHtmlElements?
Contributor
|
Thank you for the pull request. Could you add automated tests for these changes? |
Author
|
mozilla/slowparse#81 yes there should be more things added to omittableCloseTagHtmlElements . I also have some test cases in the upstream project. |
Contributor
|
@pollei happy to hear your look at pushing your changes upstream. I'm looking how to make it easier for live-editor to track changes to mozilla/slowparse. |
Contributor
|
I'm closing this for now. @pollei if you add tests please feel free to re-open this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added as an optional ommited end tag
as per http://www.w3.org/TR/html5/syntax.html#optional-tags
updated README to deal with some link-rot
modified: external/slowparse/README.md
modified: external/slowparse/slowparse.js
https://www.khanacademy.org/profile/spollei/