-
Notifications
You must be signed in to change notification settings - Fork 3
Add containers from Letheia Expanded and bk3k Blocks and Objects #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Added the huge locker in bk3k Blocks and Objects https://steamcommunity.com/sharedfiles/filedetails/?id=757860462
Adding the first container for the Legion
Duplicates of the script for the other Letheia containers
Added Letheia Expanded Bookcase https://steamcommunity.com/sharedfiles/filedetails/?id=1987992979
Added the rest of the Letheia Expanded containers.
|
just to make sure, you completely tested this first, right? The lack of metadata changes says "probably not". you'll need to find the "name" field from those two mods' metadata files (not "friendlyName") to add to includes |
Added includes for the two mods
|
I have updated the includes in the metadata, but this needs more testing. Like many things, it seemed a lot simpler at first glance. What exactly is needed with the supportedcontainers.config.patch - do all of the items in the patch need to be added to that file? |
|
any containers that are to be supported by the storage expander |
Need comments on this as I am not sure on where the error is
…bjects/shipyard/bk3k_stationWarehouseLocker/bk3k_stationWarehouseLocker.object.patch
Deleting and reuploading was faster than editing each file
Did this to match the main build
Damn it, forgot to close parantheses
fixed copy paste error
|
I was able to get the Letheia Expanded containers working partially - they can be sorted and carried with objects inside. If you have suggestions on which approach to take with the bk3k container, let me know. I created another fork to test out the supported containers patch, since it was causing errors in the lua script for the storage Expander. If you could take a look at the code in that branch, I'd appreciate it |
|
a simple json linter would have answered that. COMMAS. your supported containers patch is missing plenty. |
JSONLint is my new best friend. Tested with both mods and it works
Now works, although with a lower storage capacity than before. I used code from the Enhanced Storage mod here
Jsonlint applied to both changes
|
Sorry about not getting back to you sooner, work was keeping me busy. I have applied sufficient commas to the patch files. I was able to upgrade storage on Letheia Expanded objects with no problems, and the bk3k container is now a 300 slot container. This was certainly a learning experience, and I appreciate your patience. |
|
at least you didnt completely forget this exists. mind changing something? due to...potential issues...I'd rather you swap the bk3k container to something equal to/higher than the original |
Changed to a larger value that the default 399. 540 is the next chest size that has a UI.
|
The next level of container supported by Enhanced Storage has 540 slots. (there's no 400 or 500 slot option for chest interfaces) I increased it to that level. Would you suggest increasing the container sizes for Letheia Expanded to bring them in line with other enhanced storage containers, or just leave them as is? |
|
I created patch files for every container in these two mods (bk3k only has one, but it is huge and needs sorting) using the exact code used in other mod patches previously included in the project
. Letheia Expanded containers are going to be comparatively small, but I did not want to mess with slot size right now.
https://steamcommunity.com/sharedfiles/filedetails/?id=757860462
https://steamcommunity.com/sharedfiles/filedetails/?id=1987992979