[SPIR-V] Assert int width <= 64 in const selection#235
Closed
michalpaszkowski wants to merge 1 commit intofeature/spirv-backend-llvm15_0_6from
Closed
[SPIR-V] Assert int width <= 64 in const selection#235michalpaszkowski wants to merge 1 commit intofeature/spirv-backend-llvm15_0_6from
michalpaszkowski wants to merge 1 commit intofeature/spirv-backend-llvm15_0_6from
Conversation
michalpaszkowski
changed the base branch from
spirv-backend-llvm15_0_6
to
feature/spirv-backend-llvm15_0_6
michalpaszkowski
force-pushed
the
feature/spirv-backend-llvm15_0_6
branch
from
aa8fc41 to
67b9223
Compare
Member
Author
|
Closing, the change is included in #249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an assert for integer bit width. Similarly, the Khronos SPIR-V LLVM Translator does not support integers larger than i64 natively.