Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #76 , but rather opened for feedback than for merging it immediately, according to the discussion in the issue:
This is a glTF asset that is only offered as
glTF-Binary. It is a simple quad with a texture. The texture is referred to from the.glbfile as an external resource.This is not common practice. Usually, GLB files are supposed to be complete and self-contained. However, there are legitimate use-cases where people would like to store textures outside of GLB assets. (Specifically, when there are "large", texture-atlas like textures that are used in multiple small GLB assets).
So this model could serve as a test case for the ability of engines and libraries to handle this.
(And I assume that there are some toolchains and workflows that will choke on this - namely, all tools that just iterate over the
glTF-Sample-Assetsdirectory and try to load each.glbfile, assuming that it will be self-contained- That could be a reason to not add this, because it can cause an inconvenience for those who created these tools, but ... it might as well just point out a limitation . I actually just stumbled over such a limitation, on a very fundamental level, and now have to find a workaround... 🤞 )