Align KHR_materials_variants schemas with the core spec#1881
Merged
donmccurdy merged 1 commit intoKhronosGroup:masterfrom Oct 17, 2020
Merged
Align KHR_materials_variants schemas with the core spec#1881donmccurdy merged 1 commit intoKhronosGroup:masterfrom
donmccurdy merged 1 commit intoKhronosGroup:masterfrom
Conversation
emackey
approved these changes
Oct 14, 2020
Member
|
/cc @pushmatrix |
Member
|
Follows #1681 |
sleroux
approved these changes
Oct 14, 2020
Contributor
sleroux
left a comment
sleroux
left a comment
There was a problem hiding this comment.
Thanks for the clarifying update!
sleroux
approved these changes
Oct 14, 2020
Member
Author
|
@donmccurdy |
donmccurdy
reviewed
Oct 16, 2020
extensions/2.0/Khronos/KHR_materials_variants/schema/glTF.KHR_materials_variants.schema.json
Show resolved
Hide resolved
donmccurdy
approved these changes
Oct 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a technical update to align
KHR_materials_variantsschemas with the core glTF design principles.glTFProperty.extrasandextensionsneed to be mentioned explicitly.glTFChildOfRootProperty./cc @jercytryn @sleroux