winterbreak/jb.sh: fix formatting; remove undefined keywords#20
Draft
faukah wants to merge 1 commit intoKindleModding:winterbreakfrom
Draft
winterbreak/jb.sh: fix formatting; remove undefined keywords#20faukah wants to merge 1 commit intoKindleModding:winterbreakfrom
faukah wants to merge 1 commit intoKindleModding:winterbreakfrom
Conversation
Makes the current formatting a bit nicer, also does the following things: - removes the `local` keyrword. This is undefined in POSIX sh. - adds double quotes around some expressions to avoid word splitting - changes the `==` equality operator to `=`, since `==` is also not supported by POSIX sh.
Member
|
has this been tested yet? |
Author
|
no, this is why I made it a draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the current formatting a bit nicer, also does the following things:
localkeyrword. This is undefined in POSIX sh.==equality operator to=, since==is also not supported by POSIX sh.