Make the project a react library depending on trame-iframe js lib #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jourdain
reviewed
Nov 18, 2024
jourdain
reviewed
Nov 18, 2024
jourdain
reviewed
Nov 18, 2024
Collaborator
Author
finetjul
reviewed
Dec 6, 2024
bourdaisj
force-pushed
the
genericize
branch
2 times, most recently
from
2ff2c4f to
d8d0474
Compare
add a react patternfly app on how to use it license Apache 2
bourdaisj
force-pushed
the
genericize
branch
from
d8d0474 to
d571cb7
Compare
Collaborator
Author
|
Can we at least merge this one even if we don't release anything? |
Collaborator
|
Are you asking me or @finetjul ? |
Collaborator
Author
|
Sorry, asking both of you |
Collaborator
|
I'm fine merging that right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see Add a JS lib to support trame-client API through an iframe trame-iframe#2