Skip to content

menu: Added new z-offset calibration menu for non-delta printers#7189

Open
JeffPerando wants to merge 2 commits intoKlipper3d:masterfrom
JeffPerando:master
Open

menu: Added new z-offset calibration menu for non-delta printers#7189
JeffPerando wants to merge 2 commits intoKlipper3d:masterfrom
JeffPerando:master

Conversation

@JeffPerando
Copy link

I recently put Klipper on my Sovol SV06, and I found calibrating the Z-offset very laborious, particularly compared to using the stock firmware. There's a lot of going between your PC and your printer to input the necessary commands and actually performing the paper test respectively, and I wanted to simplify that.

Some notes:

  • The main intent behind a lot of the code is to ensure a good user experience; I didn't want the printer to crash because the user forgot to do something beforehand, or accidentally clicked the wrong option.
  • I didn't touch the Delta calibration menu because I don't have that style of printer to test if I break any features.
  • I did not add menu options for the bisect commands TESTZ Z=+ and TESTZ Z=- since I felt they would just clutter the menu. It's easier to adjust the offset manually in the direction that you want by a small amount.
  • The begin options run ABORT and G28 before starting the calibration test. ABORT does nothing if the user isn't already probing, and if they are, then accidentally clicking begin again just resets things, making it safer. G28 is run because homing is necessary to adjust the Z-offset, and doesn't take long, so might as well. Plus in my experience as a user, Klipper crashes if you try to do almost anything before homing, and this is a source of frustration I want to avoid.
  • I tried to make it skip the G28 instruction if the printer was already homed, but this concatenated it with the previous command, in this case ABORT, and then it just wouldn't run the following command. Example:
    • ABORT
      {%- if 'z' not in printer.toolhead.homed_axes -%}
          G28
      {%- endif -%}
      PROBE_CALIBRATE
    • // Unknown command:"ABORTG28"

Signed-off-by: Jeff Perando <jeffperando@gmail.com>
@nefelim4ag
Copy link
Collaborator

// Unknown command:"ABORTG28"

JFYI,
You can remove the - sign from the template, it is to strip symbols

-Timofey

Signed-off-by: Jeff Perando <jeffperando@gmail.com>
@github-actions
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants