Fix for issue #205 "Phoenix crashes after playing through a certain number of levels"#7
Open
Diet-Gameboy wants to merge 1 commit intoKnightOS:masterfrom
Open
Conversation
…shed function was commented out and in its place jr level_loader was there instead. I'm assuming this is what's causing that crashing behavior as when the game attempts to finish it instead just jumps to the level_loader function again causing erronious behavior. I have put the jump vector back as well as padding it with a nop to make it the required 4 bytes size. Now the game should exit correctly. -Diet_Gameboy 2-17-2025
Diet-Gameboy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On line 76 of init.asm I found that the jump vector for the game_finished function was commented out and in its place jr level_loader was there instead. I'm assuming this is what's causing that crashing behavior as when the game attempts to finish it instead just jumps to the level_loader function again causing erronious behavior. I have put the jump vector back as well as padding it with a nop to make it the required 4 bytes size. Now the game should exit correctly.