Conversation
…ll-zero values Co-authored-by: Redjaw <4438516+Redjaw@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix display issue in column chart with zero values
Fix Highcharts column chart not rendering second series when first series is all zeros
Feb 25, 2026
Contributor
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a Highcharts column chart with multiple series, if the first series contains all-zero values, the second series fails to render correctly (shows flat columns). This is a Velocity 2.x truthiness bug:
#if(0)evaluates tofalse, so every data point of the zero-valued series is silently dropped, producing an emptydata: []array that corrupts subsequent series rendering.Proposed changes
Root cause: In
column_chart.vm, the guard condition#if($row.get($serieColumnsMapped))skips rows where the series value is0because Velocity 2.3 treats integer/double zero as falsy.Fix: Move the
#setbefore the#ifand replace the falsy guard with a null-safe string check:"$!serieValue"uses Velocity's null-safe interpolation: outputs""fornull(excluded) and"0"for zero (included). Consistent with the pattern already used inscatter_chart.vm.Types of changes
Checklist
Further comments
The reverse case (first series non-zero, second series all-zero) already worked correctly — it only fails when the first series is all zeros, because the empty data array shifts Highcharts' internal series index alignment. The fix is a 2-line change with no behavioral impact on non-zero or null values.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.