Skip to content

Conversation

@shakaran
Copy link
Contributor

@shakaran shakaran commented Dec 9, 2025

Based in comment #351 (comment)

Updates the minimum required PHP version for the project from 8.1 to 8.2.

The changes ensure that all build jobs, dependency management, and code analysis workflows are aligned with PHP 8.2, and the composer.json file now enforces this new requirement.

PHP version upgrade:

  • Updated all relevant job configurations in .github/workflows/build.yaml to use PHP 8.2 instead of 8.1 for builds, dependency checks, and Symfony compatibility tests.
  • Changed the PHP requirement in composer.json from ^8.1 to ^8.2, enforcing the new minimum version for dependency management.

@stof
Copy link
Collaborator

stof commented Dec 9, 2025

The workflow changes done in the other PR were not about bumping the min PHP version (which is what this PR actually does, even if it tries to describe it as if the changes in the CI workflow were the important part).

@shakaran
Copy link
Contributor Author

shakaran commented Dec 9, 2025

ping the min PHP version (which is what this PR actually does, even if it tries to describe it as if the changes in the CI w

ok, but are you agree in bump min version of php?

@stof
Copy link
Collaborator

stof commented Dec 9, 2025

what is the benefit it brings us ?

@shakaran
Copy link
Contributor Author

shakaran commented Dec 9, 2025

what is the benefit it brings us ?

Support only PHP versions which are not EOL, and avoid maintain code for old versions.

Copy link
Contributor

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title suggests that the PR only affects the CI. In fact, the PHP requirement is bumped which has impact on downstream projects. Dropping support for older PHP releases should be a deliberate decision of the maintainers and not a side-effect of a CI configuration adjustment.

include:
- description: 'No Symfony specified'
php: '8.1'
php: '8.2'
Copy link
Contributor

@derrabus derrabus Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job does the same as the one below now. That does not make sense.

@stof
Copy link
Collaborator

stof commented Dec 9, 2025

And this brings no benefit regarding the maintenance of code for old versions, as there is nothing being removed in term of code, so the maintenance cost is exactly the same than before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants