-
Notifications
You must be signed in to change notification settings - Fork 191
feat: update worflow and composer to PHP 8.2 or upper #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The workflow changes done in the other PR were not about bumping the min PHP version (which is what this PR actually does, even if it tries to describe it as if the changes in the CI workflow were the important part). |
ok, but are you agree in bump min version of php? |
|
what is the benefit it brings us ? |
Support only PHP versions which are not EOL, and avoid maintain code for old versions. |
derrabus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title suggests that the PR only affects the CI. In fact, the PHP requirement is bumped which has impact on downstream projects. Dropping support for older PHP releases should be a deliberate decision of the maintainers and not a side-effect of a CI configuration adjustment.
| include: | ||
| - description: 'No Symfony specified' | ||
| php: '8.1' | ||
| php: '8.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job does the same as the one below now. That does not make sense.
|
And this brings no benefit regarding the maintenance of code for old versions, as there is nothing being removed in term of code, so the maintenance cost is exactly the same than before. |
Based in comment #351 (comment)
Updates the minimum required PHP version for the project from 8.1 to 8.2.
The changes ensure that all build jobs, dependency management, and code analysis workflows are aligned with PHP 8.2, and the
composer.jsonfile now enforces this new requirement.PHP version upgrade:
.github/workflows/build.yamlto use PHP 8.2 instead of 8.1 for builds, dependency checks, and Symfony compatibility tests.composer.jsonfrom^8.1to^8.2, enforcing the new minimum version for dependency management.