Fix issue with indexPath in didSelectRowAtIndexPath when a cell contains KILabel#45
Open
asenchuk wants to merge 2 commits intoKrelborn:masterfrom
Open
Fix issue with indexPath in didSelectRowAtIndexPath when a cell contains KILabel#45asenchuk wants to merge 2 commits intoKrelborn:masterfrom
asenchuk wants to merge 2 commits intoKrelborn:masterfrom
Conversation
Author
|
... and. nothing? |
|
I fixed the issue by removing for following code from "- (void)touchesEnded:(NSSet *)touches withEvent:(UIEvent *)event.
I guess the author copied code from "- (void)touchesBegan:(NSSet *)touches withEvent:(UIEvent *)event" by mistake. |
|
@mobilefellow thank you. I have just wasted two hours on this, taking my project (quite large) apart and going more crazy every minute. It was one of the most bizarre and random bugs I have seen this year. I'm so happy it works now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #30
It looks like copy-paste issue when a chunk of code at the touchesEnded was copied from touchesBegan and after super's touchesEnded super's touchesBegan is being called.
Main.storyboard was updated to make a cell selectable.
KILabelTableViewController.m updated with logging so you can check issue.
To reproduce the issue revert my changes in KILabel.m and try the following steps:
Hope you will check this PR asap because it's very useful pod.
ADDED: fix for the crash caused by adding nil color to a dict