Skip to content

Replace both times that popen("cat | grep") is used #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
magnus-ISU wants to merge 2 commits into
base: v1.x.x
Choose a base branch
from
Open

Replace both times that popen("cat | grep") is used #86

magnus-ISU wants to merge 2 commits into from

Conversation

@magnus-ISU
Copy link

@magnus-ISU magnus-ISU commented Sep 21, 2021

Since we can just open the file in python, these were easy to change.

@KrispyCamel4u
Copy link
Owner

KrispyCamel4u commented Sep 24, 2021

This works, and is faster. Thanks.
But again it would be better if you can modify pull request to v1.x.x branch rather than master.

@magnus-ISU magnus-ISU changed the base branch from master to v1.x.x September 26, 2021 03:37
@magnus-ISU
Copy link
Author

magnus-ISU commented Sep 26, 2021

Sorry. I will change that. I didn't know I should have been merging there instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@magnus-ISU @KrispyCamel4u