fix: prevent empty defaults/overrides dicts in policy spec

[crstrn13]

Description

• Fixed a bug in AuthPolicy where accessing defaults or overrides properties would immediately create empty dicts in the spec, even when no rules were added
• Changed the implementation to use lazy initialization with string markers instead of eager dict creation
• This prevents empty defaults: {} or overrides: {} sections from appearing in committed AuthPolicy specs

Changes

Bug Fix

• Modified defaults and overrides properties to use string markers ("defaults", "overrides") instead of immediately calling setdefault()
• Updated auth_section property to check for string markers and only create the dict when actually needed
• Updated strategy() method to handle string markers and create the section dict on-demand
• Added inline comments explaining the lazy initialization pattern

Technical Details

The previous implementation would create empty dicts when accessing properties:

self.spec_section = self.model.spec.setdefault("defaults", {})  # Creates empty dict immediately

New implementation uses lazy initialization:
self.spec_section = "defaults" # Just a marker, no dict created yet

The actual dict is only created when auth_section or strategy() is called to add actual configuration.

Verification steps

No test files were modified. Existing tests verify the fix:

Test defaults/overrides exclusivity rules

poetry run pytest -vv testsuite/tests/singlecluster/defaults/test_rules_exclusivity.py testsuite/tests/singlecluster/overrides/test_rules_exclusivity.py

Test that defaults/overrides functionality still works

poetry run pytest -vv testsuite/tests/singlecluster/defaults/ testsuite/tests/singlecluster/overrides/

[crstrn13]

/make kuadrant

[crstrn13]

/make kuadrant

[github-actions]

Test run has started (make kuadrant) and can be found here

[github-actions]

Test run has started (make kuadrant) and can be found here

[crstrn13]

/make kuadrant

[crstrn13]

/make kuadrant

[github-actions]

Test run has started (make kuadrant) and can be found here

[crstrn13]

/make kuadrant

[crstrn13]

/make kuadrant

[github-actions]

Test run has started (make kuadrant) and can be found here

[emmaaroche]

LGTM 👍

[averevki]

Suggested change

	if isinstance(self.spec_section, str):
	# String marker - create the section now
	section = self.model.spec.setdefault(self.spec_section, {})
	else:
	section = self.spec_section
	section = self.spec_section
	if isinstance(self.spec_section, str):
	# String marker - create the section now
	section = self.model.spec.setdefault(self.spec_section, {})

better code flow 👍