Skip to content

Bugfix for Tomo's scaffold-guided design error#1

Merged
nzrandol merged 1 commit intomainfrom
scaffoldguided_bugfix
Jul 21, 2025
Merged

Bugfix for Tomo's scaffold-guided design error#1
nzrandol merged 1 commit intomainfrom
scaffoldguided_bugfix

Conversation

@hdieckhaus
Copy link

Bugfix for error introduced by RFpeptides update (GitHub issues RosettaCommons#272 + RosettaCommons#273).

  • ScaffoldedSampler was using the wrong config variable, causing scaffold-guided design to error out
  • ScaffoldedSampler didn't define the cyclic residue parameter that RFpeptides expects, causing another error

…taCommons#272+RosettaCommons#273). ScaffoldSampler was using the wrong config variable and didn't define the cyclic residue parameter that RFpeptides expects.
@hdieckhaus hdieckhaus requested a review from nzrandol July 17, 2025 20:17
@hdieckhaus
Copy link
Author

accidentally opened up a PR on the main RFdiffusion page b/c GitHub sends you back to the source of the Fork, oops...

Copy link

@nzrandol nzrandol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nzrandol nzrandol merged commit 69f67e6 into main Jul 21, 2025
1 check failed
@nzrandol nzrandol deleted the scaffoldguided_bugfix branch July 21, 2025 15:04
@FattyChen
Copy link

Bugfix for error introduced by RFpeptides update (GitHub issues RosettaCommons#272 + RosettaCommons#273).

  • ScaffoldedSampler was using the wrong config variable, causing scaffold-guided design to error out
  • ScaffoldedSampler didn't define the cyclic residue parameter that RFpeptides expects, causing another error

How to solve this problem, "• ScaffoldedSampler didn't define the cyclic residue parameter that RFpeptides expects, causing another error", could you give specific advice ? THANKS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants